Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't set the state when error responded #456

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: Don't set the state when error responded #456

merged 1 commit into from
Sep 27, 2024

Conversation

wonchulee
Copy link
Collaborator

@wonchulee wonchulee commented Sep 27, 2024 •
edited
Loading

  • Add missing return statement to avoid performing State.Set() on error

youngmn
youngmn approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@youngmn youngmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youngmn youngmn merged commit be36e0c into NaverCloudPlatform:main Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngmn youngmn youngmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wonchulee @youngmn