Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence of listeners on the server-side #154

Draft
wants to merge 3 commits into
base: config_file
Choose a base branch
from

Conversation

k33pn3xtlvl
Copy link

Pull Request (PR) Checklist

  • I have read the CONTRIBUTING doc
  • PR is from a topic/feature/bugfix branch off the dev branch (right side)
  • PR is against the dev branch (left side)
  • Merlin compiles without errors
  • Passes linting checks and unit tests
  • Updated CHANGELOG
  • Updated README documentation (if applicable)
  • Update Merlin version number in pkg/merlin.go (if applicable)

Change Type

  • Addition
  • Bugfix
  • Modification
  • Removal
  • Security

Description

Realization approach for #105

It's an interesting project, so I wanted to take a closer look at how it works under the hood and also expand my programming skills.
Since I constantly initialize the Merlin server in a VM, repeatedly setting the listeners each time has become tiresome.

I only implemented server-side listener persistence. I do not store agent information, as I see no reason to, since this information is temporary and mostly log information.

If anything is unclear, please let me know and sorry in advanced English is not my native language.
I must admit, I found the repository's abstraction somewhat challenging. I understand the purpose of the repositories, however, from my perspective, it seems overly too fragmented, at least at the moment.

Also If you could give me some tips what I can improve, I would be very grateful.

@Ne0nd0g
Copy link
Owner

Ne0nd0g commented Feb 27, 2024

@k33pn3xtlvl Thank you so much for creating this Pull Request. Many people have asked me for something like this. I took a quick look through the code and things looks good. I'll work on doing a more in-depth code review in the next couple of weeks and merge this PR in.

Fixed: On "stop" the listener is not removed from the persistent file and on
"start" the same listener is added to the file again.
@Ne0nd0g Ne0nd0g changed the base branch from dev to config_file April 5, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants