Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit nameOfRefClass check #668

Open
skinkie opened this issue Feb 27, 2024 · 3 comments
Open

Explicit nameOfRefClass check #668

skinkie opened this issue Feb 27, 2024 · 3 comments
Labels
enhancement non semantic enhacement: technical enhancement, etc.
Milestone

Comments

@skinkie
Copy link
Contributor

skinkie commented Feb 27, 2024

I think we must be able to generated a list of values that should be usable as nameOfRefClass, so we can prevent typo's here. I would love to see some sort of reusable enumeration which also could be used within TypeOfFrame.

Related to #650

Suggestion: creating 'inception' by adding the entire Class list in here?

        <xsd:simpleType name="NameOfClass">
                <xsd:annotation>
                        <xsd:documentation>Type for name of a class of an ENTITY.</xsd:documentation>
                </xsd:annotation>
                <xsd:restriction base="xsd:Name"/>
        </xsd:simpleType>
@skinkie skinkie added the enhancement non semantic enhacement: technical enhancement, etc. label Feb 27, 2024
@ue71603
Copy link
Contributor

ue71603 commented Apr 17, 2024

@skinkie frankly not quite clear, what I should do.

@skinkie
Copy link
Contributor Author

skinkie commented Apr 17, 2024

What we should do is the question. If we take all the classes in NeTEx and would add them here as an enumeration, it would give the ability to check the correct usage of nameOfRefClass. But once a class is added, it must be added here too. If we want to be more specific nameOfRefClass might also be limited based on the elements that can be used to refer. This would require a per Ref-element list of potential classes (and hopefully a default).

@ue71603 ue71603 modified the milestones: netex_2.0, netex_2.1 Apr 17, 2024
@ue71603 ue71603 removed their assignment Apr 19, 2024
@skinkie
Copy link
Contributor Author

skinkie commented May 6, 2024

Also include FrameClassRef and ClassInFrameRef.

<FrameClassRef nameOfClass="CompositeFrame"/>
<ClassInFrameRef nameOfClass="DataManagedObject">Use Common definitions</ClassInFrameRef>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement non semantic enhacement: technical enhancement, etc.
Projects
None yet
Development

No branches or pull requests

2 participants