Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature dutypart vehicleref #36

Closed
wants to merge 7 commits into from
Closed

Feature dutypart vehicleref #36

wants to merge 7 commits into from

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Jan 4, 2019

This is a WIP. But I would really would like to see some feedback :-)

@Aurige
Copy link
Contributor

Aurige commented Jan 4, 2019

Hello Stefan
I agree that these typos should be fixed, but this is also changing some tag names, and therefore may generate some incompatibilities with previous versions. So if we decide to do this, we need to have a very clear list of such changes to be validated with the group, and also anticipate some possible solutions (like substitution group) for those already using these tags.

@skinkie
Copy link
Contributor Author

skinkie commented Jan 4, 2019

@Aurige this is the pull you want to comment on.
#35

@Aurige
Copy link
Contributor

Aurige commented Jan 4, 2019

Yes, that's this issue, fixing AccountingTIme to AccountingTime, is something we should probably do, also it changes the tag name... with possible compatibility issue

@skinkie
Copy link
Contributor Author

skinkie commented Jan 4, 2019

You are commenting on #36 not #35.

@skinkie skinkie self-assigned this Jan 7, 2019
syversenkr and others added 4 commits April 19, 2022 11:31
@syversenkr
FareZone and refs should have constraint checks in timetable XSD (NeT…
c02c591 
…Ex-CEN#154)
@Aurige
Update netex_timingPattern_version.xsd (NeTEx-CEN#333)
9330773 
* Update netex_timingPattern_version.xsd

The restiction in OnwardTimingLinkView was also containing an extension (Distance) !!
The distance has been moved to OnwardTimingLink_DerivedViewStructure  (not used elsewhere for now)
@ue71603
Travis to include newMOdes (NeTEx-CEN#331)
2d5e3ef 
* Travis to include newMOdes

* Update New Mode example

correcting errors

* correcting typos

* Include epip as well

* Update IXSI Service 1 - Static Data.xml

* include other standards

* noptis examples removed and some errors fixed

Noptis removed, because completly not working and fixed some issues (wrong URI, and 24:00:00 is not a valid xs:time)

* Problem not in noptis but in norway

removed also file from zip that is not working and corrected some more bugs

* nta also has problems

* Next list of updates

* last small change

* empty tfl causes problem therefore removed as well

* and again
@ue71603
Merge branch 'master' into feature_dutypart_vehicleref
7f3585d
@skinkie skinkie changed the base branch from master to next April 19, 2022 22:21
@skinkie skinkie added needs documentation update The NeTEx document needs to be updated needs transmodel update labels Apr 19, 2022
@skinkie
Copy link
Contributor Author

skinkie commented Apr 19, 2022

@ue71603 this is certainly a next thing :-)

@ue71603
Copy link
Contributor

ue71603 commented Apr 19, 2022

@skinkie Ok, it drags now some master things with it, it seems (all changes to the examples).

@duexw
Copy link
Collaborator

duexw commented Feb 21, 2023

Some initial comments on duties and duty parts:

DriverScheduleFrame:

  • It would be nice to have a reference to VehicleScheduleFrame

Duty:

  • Should have number / external identifier (the duty number plays a strong role in existing systems)
  • should have direct day type Reference like Block
  • Reference to a Garage or to a DutyGroup which refers to a Garage
  • either add start + end place and time or make dutyPart mandatory
  • Qualifications would be good to have

DutyPart:
Driver Access / Return Duration: Included in Start/End Time or on top?
What is the difference between this element and the driver trip times?

dutyActivities:
DriverTrips do not have explicit Start and End Time

Driving Spell:

  • Should also have Start and End Time (Reference to ReliefOpportunity is not enough)
  • Spell/VehicleJourneyRef: A spell could cover several subsequent journeys

General:
AccountableElement would need some "Type of Account", e.g. an activity might lead to several times such as driving time, night time, inconvenience surcharge...
Standby / Reserve duty are two different types of duty, how would one model reserve duty?

Much better now, but some work to be done yet

@skinkie
Copy link
Contributor Author

skinkie commented Feb 22, 2023

Is addressed in #424

@skinkie skinkie closed this Feb 22, 2023
@Aurige Aurige removed the needs documentation update The NeTEx document needs to be updated label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ue71603 ue71603 ue71603 approved these changes

@Aurige Aurige Awaiting requested review from Aurige

@duexw duexw Awaiting requested review from duexw

@klement-MENTZ klement-MENTZ Awaiting requested review from klement-MENTZ

Assignees

@skinkie skinkie

Labels
good first issue needs transmodel update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skinkie @Aurige @ue71603 @duexw @syversenkr