Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next duty #424

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Next duty #424

wants to merge 4 commits into from

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Feb 22, 2023

This is the work that @Aurige wanted to do. I already started. Next step is integrating the changes of @nick-knowles .

@skinkie skinkie changed the base branch from master to next February 22, 2023 10:19
@skinkie
Copy link
Contributor Author

skinkie commented Feb 22, 2023

TODO from @duexw

Some initial comments on duties and duty parts:

DriverScheduleFrame:

  • It would be nice to have a reference to VehicleScheduleFrame

Duty:

  • Should have number / external identifier (the duty number plays a strong role in existing systems)
  • should have direct day type Reference like Block
  • Reference to a Garage or to a DutyGroup which refers to a Garage
  • either add start + end place and time or make dutyPart mandatory
  • Qualifications would be good to have

DutyPart:
Driver Access / Return Duration: Included in Start/End Time or on top?
What is the difference between this element and the driver trip times?

dutyActivities:
DriverTrips do not have explicit Start and End Time

Driving Spell:

  • Should also have Start and End Time (Reference to ReliefOpportunity is not enough)
  • Spell/VehicleJourneyRef: A spell could cover several subsequent journeys

General:
AccountableElement would need some "Type of Account", e.g. an activity might lead to several times such as driving time, night time, inconvenience surcharge...
Standby / Reserve duty are two different types of duty, how would one model reserve duty?

Much better now, but some work to be done yet

@skinkie
Copy link
Contributor Author

skinkie commented Feb 22, 2023

Getting #421 in, is difficult...

Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>
@Aurige
Copy link
Contributor

Aurige commented Feb 22, 2023

Getting #421 in, is difficult...

I guess that we need to ask @nick-knowles to bring his addition by hand on this next_duty branch ! Since he recreated #421 from scratch, I'm not sure that a traditional merge can manage it.

@ue71603 ue71603 added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated group_decision_needed labels Nov 22, 2023
@ue71603 ue71603 added this to the netex_2.0 milestone Dec 1, 2023
@skinkie skinkie mentioned this pull request Dec 12, 2023
@ue71603 ue71603 modified the milestones: netex_2.0, netex_3.0 Dec 14, 2023
@ue71603
Copy link
Contributor

ue71603 commented Apr 10, 2024

check if this still relevant.

@ue71603 ue71603 self-assigned this Apr 10, 2024
@ue71603
Copy link
Contributor

ue71603 commented Apr 10, 2024

@skinkie @Aurige It seems that with deckplan this would be a breeze to merge, if it is still valid. Pls advise.

@nick-knowles
Copy link
Contributor

Duty stuff was only advisory and had never been systematically revised for implementation. eg to factor out common properties.
image

image

NB Time allowance does affect existing block

@Aurige
Copy link
Contributor

Aurige commented Apr 16, 2024

Postpone (not for 2.0)

@ue71603 ue71603 removed their assignment Apr 16, 2024
@nick-knowles
Copy link
Contributor

Further revisions to UML

NeTEx Duty
image

Transmodel Duty
image

NeTEx DUty Strecth

image

@nick-knowles
Copy link
Contributor

Cpmments on TODO from @duexw

Some initial comments on duties and duty parts:

DriverScheduleFrame:
It would be nice to have DriverScheduleFrame containing DUTIES - Should a Vehicle Schedue frame reference it>

Should have number / external identifier (the duty number plays a strong role in existing systems)
++ covered by privateCOdes on DataManagedObject

should have direct day type Reference like Block
++ yes . added

Reference to a Garage or to a DutyGroup which refers to a Garage

  • added to NetEAx and Transmodel. ALso TM specifues should be able to reference ORGANISATIONLA UNOT - added to NeTEx too

either add start + end place and time or make dutyPart mandatory
++ DITY PART is mandatory

Qualifications would be good to have
++ added
DutyPart:
??Driver Access / Return Duration: Included in Start/End Time or on top?
++On top>
What is the difference between this element and the driver trip times?
++ could cover non driving tasks?

dutyActivities:
DriverTrips do not have explicit Start and End Time
+yes, they are taken from the SPell ?

Driving Spell:

Should also have Start and End Time (Reference to ReliefOpportunity is not enough)
++ Added in NeTEx

Spell/VehicleJourneyRef: A spell could cover several subsequent journeys
+ derived through BLOCK?

General:
AccountableElement would need some "Type of Account", e.g. an activity might lead to several times such as driving time, night time, inconvenience surcharge...

  • Add a Type of Accountable Activity allows classifcation of axtivity
    image

Standby / Reserve duty are two different types of duty, how would one model reserve duty?
We have a STANDBY Task. Is this a new IN RESERVE TASK is it a new further classifcation of DUTY?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants