Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required IdType fixes #471

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
4ec8571
More required IdType fixes
skinkie Jul 26, 2023
cd4a6f3
Typo
skinkie Jul 26, 2023
b034777
Remove required ids from DerivedViews
skinkie Jul 26, 2023
6a8e19b
VehicleJourneyRunTime has a cardinality of 0:1
skinkie Jul 26, 2023
4cf88c0
Introducing new restrictions, and TODO's
skinkie Jul 27, 2023
8066af4
Better, but still failing
skinkie Jul 27, 2023
d6e3660
More improvements, including required order properties
skinkie Jul 27, 2023
20e6fd6
test for change of one of the TODO
ue71603 Jul 27, 2023
2b466ef
Update netex_ifopt_site_version.xsd
ue71603 Jul 27, 2023
f7997ad
Update netex_ifopt_site_version.xsd
ue71603 Jul 28, 2023
2301590
Revert "Update netex_ifopt_site_version.xsd"
ue71603 Jul 28, 2023
68338ca
Revert "Update netex_ifopt_site_version.xsd"
ue71603 Jul 28, 2023
a72adc6
Revert "test for change of one of the TODO"
ue71603 Jul 28, 2023
4fe6625
Fix id on InterchangeRuleTiming on VDV452 example.
skinkie Jul 28, 2023
8abed5f
Update FlexibleServiceProperties in NOPTIS example.
skinkie Jul 28, 2023
7db58d3
Fix DestinationDisplayVariant example
skinkie Jul 28, 2023
9b167f1
Introduce VehicleTypeZoneRestriction id and version attributes
skinkie Jul 28, 2023
bb90df4
Entrance, VehicleEntrance change
ue71603 Jul 28, 2023
b0cfdbd
Merge branch 'fix_attribute_id_use_required' of https://github.com/Ne…
ue71603 Jul 28, 2023
198c470
adding Entrance_
ue71603 Jul 28, 2023
0097ce5
Fix TopographicProjection required id and version
skinkie Jul 28, 2023
2fd8ceb
Add required order attribute to FareTableRow
skinkie Jul 28, 2023
7a99a15
Make sure FareTableColumn has a required order element
skinkie Jul 28, 2023
6789446
Introduce version and id attributes for AlternativeNameMake sure Fare…
skinkie Jul 28, 2023
02e93ca
SubstitionGroup Entrance_ fixed substitutionGroup TyoeOfEntity_ fixed
ue71603 Jul 29, 2023
30dd071
Fixing Point_
ue71603 Jul 29, 2023
bcfe427
Fixing Zone_ substitutionGroup
ue71603 Jul 29, 2023
2716f67
removed ambiguity from GeneralFrameMember
ue71603 Jul 29, 2023
86c7891
corrected SignEquipment substitutionGroup
ue71603 Jul 29, 2023
c3ec847
fixed substitutionGroup CustomerService for better id
ue71603 Jul 29, 2023
d624884
fixing AccessRightInProduct substitutionGroup
ue71603 Jul 29, 2023
9c6737e
Fixing Entrance problem. Typo changed
ue71603 Aug 3, 2023
0886b7a
changing refs to xxx_ elements
ue71603 Aug 3, 2023
a84cde5
Lint and update documentation tables
github-actions[bot] Aug 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="CompositeVersionFrameGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="CompositeFrameIdType">
<xsd:attribute name="id" type="CompositeFrameIdType" use="required">
<xsd:annotation>
<xsd:documentation>identifier of Frame.</xsd:documentation>
</xsd:annotation>
Expand Down
24 changes: 22 additions & 2 deletions xsd/netex_framework/netex_frames/netex_generalFrame_version.xsd
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="GeneralFrameGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="GeneralFrameIdType"/>
<xsd:attribute name="id" type="GeneralFrameIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -219,6 +219,26 @@ Rail transport, Roads and Road transport
<xsd:annotation>
<xsd:documentation>An association of an ENTITY in a GENERAL FRAME.</xsd:documentation>
</xsd:annotation>
<!-- TODO: Matthias
<xsd:complexType>
<xsd:complexContent>
<xsd:restriction base="GeneralFrameMemberStructure">
<xsd:sequence>
<xsd:sequence>
<xsd:group ref="EntityInVersionGroup" minOccurs="0"/>
</xsd:sequence>
<xsd:sequence>
<xsd:group ref="DataManagedObjectGroup"/>
</xsd:sequence>
<xsd:sequence>
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
<xsd:group ref="GeneralFrameMemberGroup"/>
</xsd:sequence>
<xsd:attribute name="id" type="GeneralFrameMemberIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType> -->
</xsd:element>
<xsd:complexType name="GeneralFrameMemberStructure" abstract="false">
<xsd:annotation>
Expand All @@ -228,7 +248,7 @@ Rail transport, Roads and Road transport
<xsd:extension base="VersionedChildStructure">
<xsd:group ref="GeneralFrameMemberGroup">
<xsd:annotation>
<xsd:documentation>Elements of a GENERAL FRAME MEMBER. Note that VersionOfObjectRef is used too implement ENTITY IN VERSION IN FRAME.</xsd:documentation>
<xsd:documentation>Elements of a GENERAL FRAME MEMBER. Note that VersionOfObjectRef is used to implement ENTITY IN VERSION IN FRAME.</xsd:documentation>
</xsd:annotation>
</xsd:group>
</xsd:extension>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="ResourceFrameGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="ResourceFrameIdType"/>
<xsd:attribute name="id" type="ResourceFrameIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="ServiceCalendarFrameGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="ServiceCalendarFrameIdType"/>
<xsd:attribute name="id" type="ServiceCalendarFrameIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="SensoryLimitationGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="LimitationIdType"/>
<xsd:attribute name="id" type="LimitationIdType" use="optional"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -143,7 +143,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="AccessibilityAssessmentGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="AccessibilityAssessmentIdType"/>
<xsd:attribute name="id" type="AccessibilityAssessmentIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ Rail transport, Roads and Road transport
</xsd:element>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="UserNeedIdType"/>
<xsd:attribute name="id" type="UserNeedIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -294,7 +294,7 @@ Rail transport, Roads and Road transport
</xsd:element>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="SuitabilityIdType"/>
<xsd:attribute name="id" type="SuitabilityIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ Rail transport, Roads and Road transport
<xsd:documentation>Name of Class of the ENTITY. Allows reflection. Fixed for each ENTITY type.</xsd:documentation>
</xsd:annotation>
</xsd:attribute>
<xsd:attribute name="id" type="AlternativeNameIdType"/>
<xsd:attribute name="id" type="AlternativeNameIdType" use="required"/>
<xsd:attribute name="dataSourceRef" type="DataSourceIdType" use="optional">
<xsd:annotation>
<xsd:documentation>Name of source of the data.</xsd:documentation>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Rail transport, Roads and Road transport
</xsd:group>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="ContactIdType"/>
<xsd:attribute name="id" type="ContactIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="GeneralGroupOfEntitiesGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="GroupOfEntitiesIdType" use="optional">
<xsd:attribute name="id" type="GroupOfEntitiesIdType" use="required">
<xsd:annotation>
<xsd:documentation>Identifier of ENTITY.</xsd:documentation>
</xsd:annotation>
Expand Down Expand Up @@ -211,7 +211,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="PurposeOfGroupingGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="PurposeOfGroupingIdType"/>
<xsd:attribute name="id" type="PurposeOfGroupingIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element name="members" type="objectRefs_RelStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Members of GROUP OF ENTITies.</xsd:documentation>
<xsd:documentation>Members of GROUP OF ENTITies.</xsd:documentation>
</xsd:annotation>
</xsd:element>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="LayerIdType"/>
<xsd:attribute name="id" type="LayerIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Rail transport, Roads and Road transport
</xsd:group>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="OrganisationIdType"/>
<xsd:attribute name="id" type="OrganisationIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -348,7 +348,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="OrganisationPartGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="OrganisationPartIdType"/>
<xsd:attribute name="id" type="OrganisationPartIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -446,7 +446,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="DepartmentGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="DepartmentIdType"/>
<xsd:attribute name="id" type="DepartmentIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -511,7 +511,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="OrganisationalUnitGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="OrganisationalUnitIdType"/>
<xsd:attribute name="id" type="OrganisationalUnitIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -567,7 +567,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="RelatedOrganisationGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="RelatedOrganisationIdType"/>
<xsd:attribute name="id" type="RelatedOrganisationIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -654,7 +654,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="AdministrativeZoneGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="AdministrativeZoneIdType"/>
<xsd:attribute name="id" type="AdministrativeZoneIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -731,7 +731,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="CodespaceAssignmentGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="CodespaceAssignmentIdType" use="optional"/>
<xsd:attribute name="id" type="CodespaceAssignmentIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -818,7 +818,7 @@ Rail transport, Roads and Road transport
<!-- ======================================================================= -->
<xsd:element name="TypeOfCodespaceAssignment" abstract="false" substitutionGroup="TypeOfValue">
<xsd:annotation>
<xsd:documentation>Classification of an CODESPACE ASSIGNMENT </xsd:documentation>
<xsd:documentation>Classification of an CODESPACE ASSIGNMENT</xsd:documentation>
</xsd:annotation>
<xsd:complexType>
<xsd:complexContent>
Expand All @@ -834,7 +834,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfCodespaceAssignmentIdType"/>
<xsd:attribute name="id" type="TypeOfCodespaceAssignmentIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -866,7 +866,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfOrganisationIdType"/>
<xsd:attribute name="id" type="TypeOfOrganisationIdType" use="required"/>
<xsd:attribute name="nameOfClassifiedEntityClass" type="NameOfClass" use="optional" fixed="Organisation">
<xsd:annotation>
<xsd:documentation>Name of Class of the ENTITY. Allows reflection. Fixed for each ENTITY type.</xsd:documentation>
Expand Down Expand Up @@ -903,7 +903,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfOrganisationPartIdType"/>
<xsd:attribute name="id" type="TypeOfOrganisationPartIdType" use="required"/>
<xsd:attribute name="nameOfClassifiedEntityClass" type="NameOfClass" use="optional" fixed="OrganisationPart">
<xsd:annotation>
<xsd:documentation>Name of Class of the ENTITY. Allows reflection. Fixed for each ENTITY type.</xsd:documentation>
Expand Down Expand Up @@ -940,7 +940,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfOperationIdType"/>
<xsd:attribute name="id" type="TypeOfOperationIdType" use="required"/>
<xsd:attribute name="nameOfClassifiedEntityClass" type="NameOfClass" use="optional" fixed="Operation">
<xsd:annotation>
<xsd:documentation>Name of Class of the ENTITY. Allows reflection. Fixed for each ENTITY type.</xsd:documentation>
Expand Down Expand Up @@ -1030,7 +1030,7 @@ Rail transport, Roads and Road transport
</xsd:group>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="ContactIdType"/>
<xsd:attribute name="id" type="ContactIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfTransferIdType"/>
<xsd:attribute name="id" type="TypeOfTransferIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -244,7 +244,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfPlaceIdType"/>
<xsd:attribute name="id" type="TypeOfPlaceIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfLinkSequenceIdType"/>
<xsd:attribute name="id" type="TypeOfLinkSequenceIdType" use="required"/>
<xsd:attribute name="nameOfClassifiedEntityClass" type="NameOfClass" use="optional" fixed="LinkSequence">
<xsd:annotation>
<xsd:documentation>Name of Class of the ENTITY. Allows reflection. Fixed for each ENTITY type.</xsd:documentation>
Expand Down Expand Up @@ -274,7 +274,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="GroupOfLinkSequencesGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="GroupOfLinkSequencesIdType"/>
<xsd:attribute name="id" type="GroupOfLinkSequencesIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,26 @@ Rail transport, Roads and Road transport
<xsd:annotation>
<xsd:documentation>A 0-dimensional node of the network used for the spatial description of the network. POINTs may be located by a LOCATION in a given LOCATING SYSTEM.</xsd:documentation>
</xsd:annotation>
<!-- TODO: Matthias
<xsd:complexType>
<xsd:complexContent>
<xsd:restriction base="Point_VersionStructure">
<xsd:sequence>
<xsd:sequence>
<xsd:group ref="EntityInVersionGroup" minOccurs="0"/>
</xsd:sequence>
<xsd:sequence>
<xsd:group ref="DataManagedObjectGroup"/>
</xsd:sequence>
<xsd:sequence>
<xsd:group ref="PointGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="PointIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
-->
</xsd:element>
<xsd:complexType name="Point_VersionStructure" abstract="false">
<xsd:annotation>
Expand Down Expand Up @@ -286,7 +306,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="PointOnLinkGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="PointOnLinkIdType"/>
<xsd:attribute name="id" type="PointOnLinkIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -355,7 +375,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfPointIdType"/>
<xsd:attribute name="id" type="TypeOfPointIdType" use="required"/>
<xsd:attribute name="nameOfClassifiedEntityClass" type="NameOfClass" use="optional" fixed="Point">
<xsd:annotation>
<xsd:documentation>Name of Class of the ENTITY. Allows reflection. Fixed for each ENTITY type.</xsd:documentation>
Expand Down Expand Up @@ -392,7 +412,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="TypeOfValueGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="TypeOfLinkIdType"/>
<xsd:attribute name="id" type="TypeOfLinkIdType" use="required"/>
<xsd:attribute name="nameOfClassifiedEntityClass" type="NameOfClass" use="optional" fixed="Link">
<xsd:annotation>
<xsd:documentation>Name of Class of the ENTITY. Allows reflection. Fixed for each ENTITY type.</xsd:documentation>
Expand Down Expand Up @@ -444,7 +464,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="GroupOfPointsGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="GroupOfPointsIdType"/>
<xsd:attribute name="id" type="GroupOfPointsIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down Expand Up @@ -508,7 +528,7 @@ Rail transport, Roads and Road transport
<xsd:group ref="GroupOfLinksGroup"/>
</xsd:sequence>
</xsd:sequence>
<xsd:attribute name="id" type="GroupOfLinksIdType"/>
<xsd:attribute name="id" type="GroupOfLinksIdType" use="required"/>
</xsd:restriction>
</xsd:complexContent>
</xsd:complexType>
Expand Down
Loading
Loading