-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature duty daytype #684
Draft
skinkie
wants to merge
29
commits into
next
Choose a base branch
from
feature_duty_daytype
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature duty daytype #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft to add the Duty Stretch and other Driver Duty elements to NeTEx. See presentation at https://3.basecamp.com/3256016/buckets/2570434/uploads/5862915177 1) Factors out Time allowances into separate abstract superclasses 2) Adds extensive 23) Adds a new Duty Stretch Example Several issues are unresolved as they need discussion (Assigned/Duty See presentation
skinkie
added
the
enhancement
non semantic enhacement: technical enhancement, etc.
label
Mar 18, 2024
trurlurl
added
the
needs documentation update
The NeTEx document needs to be updated
label
Mar 19, 2024
@skinkie why did you add this to version 3.0? Not to 2.0? |
ue71603
previously approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me
@trurlurl can you do a deep dive into the structure? |
trurlurl
requested changes
Mar 24, 2024
xsd/netex_framework/netex_reusableComponents/netex_employee_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_framework/netex_reusableComponents/netex_employee_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_framework/netex_reusableComponents/netex_employee_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_framework/netex_reusableComponents/netex_employee_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_framework/netex_reusableComponents/netex_employee_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_part_2/part2_driverManagement/netex_driver_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_part_2/part2_driverManagement/netex_driver_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_part_2/part2_driverManagement/netex_dutyStretch_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_part_2/part2_driverManagement/netex_dutyStretch_version.xsd
Outdated
Show resolved
Hide resolved
xsd/netex_part_2/part2_driverManagement/netex_dutyStretch_version.xsd
Outdated
Show resolved
Hide resolved
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
ue71603
reviewed
Mar 26, 2024
xsd/netex_framework/netex_reusableComponents/netex_employee_version.xsd
Outdated
Show resolved
Hide resolved
…nt_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
….xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…on.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ort.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…ion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
non semantic enhacement: technical enhancement, etc.
needs documentation update
The NeTEx document needs to be updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #418
The VDV example fails because the introduced StartPoints and EndPoints do not exist in the file. Should be resolved first.
@nick-knowles mentions several times this is a draft. Some things must be resolved first.
Typo reviews gracefully accepted. If someone feels like fixing the VDV example would be there thing, please do so.