Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize TAP TSI validation #743

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Prioritize TAP TSI validation #743

wants to merge 3 commits into from

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Jun 26, 2024

No description provided.

@Aurige Aurige mentioned this pull request Jun 26, 2024
Open
@ue71603
Copy link
Contributor

ue71603 commented Jun 27, 2024

...I duplicated your work....

@skinkie
Copy link
Contributor Author

skinkie commented Jun 27, 2024

...I duplicated your work....

Did you get paid for it?

@Aurige Aurige mentioned this pull request Jul 16, 2024
Merged
@skinkie skinkie closed this Jul 25, 2024
@ue71603 ue71603 reopened this Oct 15, 2024
@ue71603
Copy link
Contributor

ue71603 commented Oct 15, 2024

@Aurige @skinkie I updated everything exept two files
Netex_tap_trainhotel_1.xml and Netex_tap_tsi-B2-71-optimised.xml

The have a different problem
The assume there are:

  • validityParameterAssignments/GenericParameterAssignmentRef
  • noticeAssignments/NoticeAssignmentRef
  • FareStructureElement/accessRightParameterAssignments
  • other fare stuff

It seems to me that those reference something that doesn't exist.

Perhaps @nick-knowles can have a go at it. But I think these two examples not to be reexamined.

@ue71603 ue71603 added this to the netex_2.0 milestone Oct 15, 2024
@ue71603 ue71603 added the bug Technical mistake, inconsistency with the documentation, etc. label Oct 15, 2024
EU-Agency-for-Railways
EU-Agency-for-Railways reviewed Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@EU-Agency-for-Railways EU-Agency-for-Railways left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes OK for File Netex_tap_tsi_B2-71-optimised.xml and Netex_tap_trainhotel_1.xml @nick-knowles could check the errors

@Aurige
Copy link
Contributor

Aurige commented Oct 29, 2024

@nick-knowles to check why de 2 blocking files are not in the XML Spy project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EU-Agency-for-Railways EU-Agency-for-Railways EU-Agency-for-Railways left review comments

@nick-knowles nick-knowles Awaiting requested review from nick-knowles

@Aurige Aurige Awaiting requested review from Aurige

@ue71603 ue71603 Awaiting requested review from ue71603

@trurlurl trurlurl Awaiting requested review from trurlurl

At least 2 approving reviews are required to merge this pull request.

Assignees

@nick-knowles nick-knowles

Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Milestone
netex_2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@skinkie @ue71603 @Aurige @EU-Agency-for-Railways @nick-knowles