-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking for all examples #746
base: next
Are you sure you want to change the base?
Conversation
This is only updating the checker function. Nick is working on an update. If we need to do something with the enum, we will have to discuss it (or you already did yesterday in the meeting) |
@@ -9,7 +9,7 @@ set -e | |||
|
|||
echo "Validating NeTEx XML examples ..." | |||
|
|||
if xmllint --noout --schema xsd/NeTEx_publication.xsd examples/standards/epiap/*xml examples/functions/deckPlans/*.xml examples/standards/epiap/*xml && xmllint --noout --schema xsd/NeTEx_publication.xsd examples/functions/calendar/*.xml examples/functions/fares/*xml examples/functions/grouping/*xml examples/functions/newModes/*xml examples/functions/patterns/*xml examples/functions/pointOfInterest/*xml examples/functions/simpleNetwork/*xml examples/functions/site/*xml examples/functions/stopPlace/*xml examples/functions/timetable/*xml examples/functions/validityCondition/*xml examples/functions/variant/*xml examples/functions/vehicleSchedule/*xml examples/functions/versioning/*xml examples/standards/epip/*xml examples/standards/era_uic/*xml examples/standards/fxc/*xml examples/standards/gbfs/*xml examples/standards/gtfs/*xml examples/standards/neptune/*xml examples/standards/noptis/*xml examples/standards/tap_tsi/*xml examples/standards/txc/*xml examples/standards/vdv452/*/*xml examples/standards/vdv452/*/*/*xml; then | |||
if xmllint --noout --schema xsd/NeTEx_publication.xsd examples/standards/*xml examples/standards/*/*xml examples/standards/*/*/*xml && xmllint --noout --schema xsd/NeTEx_publication.xsd examples/functions/*xml examples/functions/*/*xml examples/functions/*/*/*xml examples/functions/*/*/*/*xml; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails due to xmllint breaking on epiap.
We want this one if the xmllint stuff is resolved; |
I'm a bit puzzled, because some files that are failing here (like tap_tsi\B3_Special\Netex_tap_tsi_B3+more.xml ) are validating on next for me |
@Aurige I think in principle we must fix the examples in master first. |
Yes that's of course fine to fix them in master, however I don't understand why the first error (and most of the others) is examples/standards/efp/VVS_Fares_V1-ZoneSeries-nk3.xml:585: element StakeholderRoleType: Schemas validity error : Element '{http://www.netex.org.uk/netex}StakeholderRoleType': [facet 'enumeration'] The value 'EntityLegalOwnership' is not an element of the set {'planning', 'operation', 'control', 'reservation', 'entityLegalOwnership', 'fareManagement', 'financing', 'securityManagement', 'customerService', 'dataRegistrar', 'tenant', 'facilityManagement', 'lessor', 'dataRegistrar', 'other'}. But even if deprecated, EntityLegalOwnership does now exist and should not raise an error (the list of possible values in the error message is not the right one currently in next) |
Non validating example will be (temporarily) dropped at publication time |
In reality probable some examples correctly should no longer work. VDV 452 examples are not in a NeTEX 2.0 format.