Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New better timetable example from Slovenia #765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atibaut
Copy link
Contributor

@atibaut atibaut commented Aug 29, 2024

This example of a timetable replaces the file Netex_09.2_Bus_SimpleTimetable_Slovenia.xml. The timetable was created from a national NeTEx service in Slovenia (Ministry of Transport/NCUP).

This example of a timetable replaces the file Netex_09.2_Bus_SimpleTimetable_Slovenia.xml. The timetable was created from a national NeTEx service in Slovenia (Ministry of Transport/NCUP).
@Aurige
Copy link
Contributor

Aurige commented Aug 29, 2024

fine for me, but maybe put if in NeTEx\examples\standards\slovenia rather than in NeTEx\examples\functions\timetable ?

@skinkie
Copy link
Contributor

skinkie commented Sep 4, 2024

@atibaut my suggestion would be to change pos to posList. That would already save a considerable amount of data.
I notice the namespace "p10:" please define this at the top level of the document als gml:

                           <LineString
                                p10:id="SI_SI0_LineStringType_00000000-1177-000a-0011-236e001135bb_IJPP"
                                xmlns:p10="http://www.opengis.net/gml/3.2"
                                xmlns="http://www.opengis.net/gml/3.2">

I notice that ScheduledStopPointRef, ServiceLinkRef, OperatingDayRef, DayTypeRef all lack the version attribute, that this is not being picked up, is a bug in the XML Schema.

                                <StopPointInJourneyPattern
                                    id="SI:SI0:StopPointInJourneyPattern:00000000-1177-0009-0000-000000725b39:IJPP"
                                    created="2023-10-06T04:51:58.9174842Z" version="1" order="7">
                                    <ScheduledStopPointRef
                                        ref="SI:SI0:ScheduledStopPoint:00000000-1177-0003-0000-00000011258e:IJPP"
                                    />
                                <ServiceLinkInJourneyPattern
                                    id="SI:SI0:ServiceLinkInJourneyPattern:00000000-1177-0009-0072-5b4100725b40:IJPP"
                                    created="2023-10-06T04:51:58.9174842Z" version="1" order="14">
                                    <ServiceLinkRef
                                        ref="SI:SI0:ServiceLink:00000000-1177-0003-0011-372900113744:IJPP"
                                    /> 
                                </ServiceLinkInJourneyPattern>
                        <DayTypeAssignment
                            id="SI:SI0:DayTypeAssignment:00000000-1177-0005-0000-062400010e54:IJPP"
                            created="2023-10-26T08:11:03.7694927Z" version="2" order="345">
                            <OperatingDayRef
                                ref="SI:SI0:OperatingDay:00000000-1177-0005-0000-01b70000594d:IJPP"/>
                            <DayTypeRef version="1"
                                ref="SI:SI0:DayType:00000000-1177-0004-0000-06240000065e:IJPP"/>
                        </DayTypeAssignment>

@nick-knowles
Copy link
Contributor

This is not true the attribute is present but optional. because you may choose to have versionRef or version defepending on whether it is an internal or external ref.

@ue71603 ue71603 added the change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. label Sep 10, 2024
@ue71603 ue71603 self-requested a review September 10, 2024 12:35
@ue71603
Copy link
Contributor

ue71603 commented Sep 24, 2024

@atibaut pls update the PR

@Aurige Aurige added this to the netex_2.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants