-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OccupancyView also possible directly in ServiceFrame #784
base: next
Are you sure you want to change the base?
Conversation
@@ -220,6 +220,17 @@ The Calendar is shown coded as | |||
<VehicleModes>bus</VehicleModes> | |||
</ScheduledStopPoint> | |||
</scheduledStopPoints> | |||
<occupancies> | |||
<OccupancyView version="any" id="occinFrame"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how a OccupancyView at this point. I think it must not be a view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other elements available. It always was a View and never anything else. You wanted it here. Sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I want to have an Occupancy here.
There exists currently only OccupancyView. So what do you want? Renaming? Wrapper? |
I want to see Occupancy to be a first class element. For this to work something more is required. At is point, nothing references to it. And it is also not describing itself what it is providing the occupancy for. |
Then this is no longer a small PR, but a full fledged one. And the question can be asked, why it supports only a part of what is possible in SIRI. |
The group discussion was for an OccupancyView (cf #605 ) so that looks fine to me ... Shall we discuss it again ? |
I was in that meeting, and the idea was to make Occupancy a first class object, not a view. |
The Full TM compliant Occupancy was identified as too rich and not fulfilling our more simple requirements, so a SIRI inspired view was decided ... but you can draft a fully TM compliant Occupancy for next release |
@skinkie currently set for 3.0. Do you need it before? |
is there any possible ref from Jouneys to that OccupancyView ? |
fixes #757