Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OccupancyView also possible directly in ServiceFrame #784

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Sep 30, 2024

fixes #757

@ue71603 ue71603 added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated labels Sep 30, 2024
@ue71603 ue71603 added this to the netex_2.0 milestone Sep 30, 2024
@@ -220,6 +220,17 @@ The Calendar is shown coded as
<VehicleModes>bus</VehicleModes>
</ScheduledStopPoint>
</scheduledStopPoints>
<occupancies>
<OccupancyView version="any" id="occinFrame">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how a OccupancyView at this point. I think it must not be a view.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other elements available. It always was a View and never anything else. You wanted it here. Sorry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I want to have an Occupancy here.

@ue71603
Copy link
Contributor Author

ue71603 commented Sep 30, 2024

There exists currently only OccupancyView. So what do you want? Renaming? Wrapper?

@skinkie
Copy link
Contributor

skinkie commented Sep 30, 2024

I want to see Occupancy to be a first class element. For this to work something more is required. At is point, nothing references to it. And it is also not describing itself what it is providing the occupancy for.

@ue71603
Copy link
Contributor Author

ue71603 commented Sep 30, 2024

Then this is no longer a small PR, but a full fledged one. And the question can be asked, why it supports only a part of what is possible in SIRI.

@ue71603 ue71603 marked this pull request as draft September 30, 2024 15:33
@ue71603 ue71603 changed the title OccupancyView also possible directly in SiteFrame OccupancyView also possible directly in ServiceFrame Sep 30, 2024
@ue71603 ue71603 modified the milestones: netex_2.0, netex_3.0 Sep 30, 2024
@Aurige
Copy link
Contributor

Aurige commented Oct 8, 2024

The group discussion was for an OccupancyView (cf #605 ) so that looks fine to me ... Shall we discuss it again ?

@skinkie
Copy link
Contributor

skinkie commented Oct 8, 2024

I was in that meeting, and the idea was to make Occupancy a first class object, not a view.

@Aurige
Copy link
Contributor

Aurige commented Oct 9, 2024

The Full TM compliant Occupancy was identified as too rich and not fulfilling our more simple requirements, so a SIRI inspired view was decided ... but you can draft a fully TM compliant Occupancy for next release

@ue71603
Copy link
Contributor Author

ue71603 commented Oct 15, 2024

@skinkie currently set for 3.0. Do you need it before?

@Aurige
Copy link
Contributor

Aurige commented Oct 16, 2024

is there any possible ref from Jouneys to that OccupancyView ?
More discussion needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants