Stratification of transport mode enumerations #791
Conversation
trurlurl
added
enhancement
| @@ -731,7 +731,7 @@ Rail transport, Roads and Road transport | |||
| <xsd:documentation>Elements for an TRANSPORT ADMINISTRATIVE ZONE.</xsd:documentation> | |||
| </xsd:annotation> | |||
| <xsd:sequence> | |||
| <xsd:element name="VehicleModes" type="AllModesListOfEnumerations" default="all" minOccurs="0"> | |||
There was a problem hiding this comment.
This looks like having been the wrong before.
| @@ -114,9 +114,9 @@ Rail transport, Roads and Road transport | |||
| <xsd:documentation>Elements for a TICKETING EQUIPMENT.</xsd:documentation> | |||
| </xsd:annotation> | |||
| <xsd:sequence> | |||
| <xsd:element name="VehicleModes" type="AllModesListOfEnumerations" minOccurs="0"> | |||
There was a problem hiding this comment.
This looks like having been the wrong before.
| @@ -112,41 +112,13 @@ Rail transport, Roads and Road transport | |||
| <xsd:list itemType="AccessModeEnumeration"/> | |||
| </xsd:simpleType> | |||
| <!--======Vehicle===================================================================================--> | |||
| <xsd:element name="VehicleMode" type="AllModesEnumeration"> | |||
There was a problem hiding this comment.
This looks like having been the wrong before.
| <!--======Modes===================================================================================--> | ||
| <xsd:element name="RoadVehicleMode" type="AllModesEnumeration"> |
There was a problem hiding this comment.
This looks like having been the wrong before.
|
@Aurige @Ulf9 @nick-knowles to check |
There was a problem hiding this comment.
If we are to make any changes we should try to align the suggested type-names and annotation as far as possible with what Transmodel 6.2 states to not further add to the confusion. I am not sure that the suggested changes do align with Transmodel 6.2. We need to basically separate between the combination of conventional modes of operation with alternative modes of operation on one side i. e. "advertised transport" and personal modes of operation e.g. with your own bike or your own car (when you are not car-sharing) on the other side. This is represented in Transmodel as either PUBLIC TRANSPORT MODE or PERSONAL MODE.
If you wish to generalise PUBLIC TRANSPORT MODE and PERSONAL MODE you use the term MODE.
These three terms are defined in Transmodel as:
MODE :
A broad characterisation of the means of movement and / or operational aspect in consideration (e.g., by bus, by train, by metro, by ferry, by foot, by private car, etc.).
PUBLIC TRANSPORT MODE:
A MODE used for public transport services (e.g., by bus, by tram, by metro, by train, by ferry, by ship, by shared taxi car, by shared car) under either a CONVENTIONAL MODE OF OPERATION or an ALTERNATIVE MODE OF OPERATION (i.e., excluding a PERSONAL MODE OF OPERATION).
Note: Prior to TM 6.2 this was named VEHICLE MODE
PERSONAL MODE :
A MODE used outside of public transport services (e.g., by private car, by private cycle, by private scooter, by private boat) under a PERSONAL MODE OF OPERATION.
Thus, please change the terminology of type-names and annotation accordingly and use capital letters only in accordance with Transmodel.
This resolves issue #772. Stratified
VehicleModeEnumeration, AllVehicleModesOfTransportEnumeration, AllModesEnumerationto ony two:AllVehicleModesOfTransportEnumerationandAllModesOfTransportEnumeration.VehicleModenow uniformly maps toAllVehicleModesOfTransportEnumeration.TransportModemaps to bothAllVehicleModesOfTransportEnumerationandAllModesOfTransportEnumeration, but context and annotations prevent confusion, in my view.The changes should keep backwards compatibilty, though I changed the mappings (to an enumeration type) at a few places where I thought the chosen enumeration likely to be erroneous. I'm going to mark them in this PR.