Improve migration process (#80)

* Get balances from the aurora engine * Remove extra `with_attached_deposit` * Fix migration tests * Remove `account_storage_usage` * Remove `account_storage_usage` * Remove `minimal` component * Update dependencies * Update `contract_state.borsh` * Update dependencies
Near-One · Apr 28, 2024 · abc7952 · abc7952
1 parent c3c946b
commit abc7952
Show file tree

Hide file tree

Showing 7 changed files with 99 additions and 174 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/contract_state.borsh b/contract_state.borsh
diff --git a/eth-connector-tests/Cargo.toml b/eth-connector-tests/Cargo.toml
@@ -27,9 +27,9 @@ near-workspaces = "0.9"
 hex = "0.4.3"
 ethabi = "18.0"
 rlp = { version = "0.5.0", default-features = false }
-aurora-engine-migration-tool = { git = "https://github.com/aurora-is-near/aurora-engine-migration-tool.git", tag = "0.2.2" }
-aurora-workspace-eth-connector = { git = "https://github.com/aurora-is-near/aurora-workspace", rev = "1d883cd9695fbd82e2c3f024d3f127769a48dfeb" }
-aurora-workspace-utils = { git = "https://github.com/aurora-is-near/aurora-workspace", rev = "1d883cd9695fbd82e2c3f024d3f127769a48dfeb" }
+aurora-engine-migration-tool = { git = "https://github.com/aurora-is-near/aurora-engine-migration-tool.git", rev = "138c9c53d806e4d231b6bbcd3fa662cc4130d237" }
+aurora-workspace-eth-connector = { git = "https://github.com/aurora-is-near/aurora-workspace", rev = "1856ffb7dd7233619e279c7223798f83008c26b2" }
+aurora-workspace-utils = { git = "https://github.com/aurora-is-near/aurora-workspace", rev = "1856ffb7dd7233619e279c7223798f83008c26b2" }
 
 [features]
 migration-tests = []
diff --git a/eth-connector-tests/src/migration.rs b/eth-connector-tests/src/migration.rs
@@ -1,18 +1,19 @@
 use crate::utils::TestContract;
-use aurora_engine_migration_tool::{BorshDeserialize, NEP141Wei, StateData};
+use aurora_engine_migration_tool::{BorshDeserialize, StateData};
 use aurora_workspace_eth_connector::types::{MigrationCheckResult, MigrationInputData};
-use near_sdk::Balance;
 use near_workspaces::AccountId;
 use std::collections::HashMap;
 use std::str::FromStr;
 
+const DEFAULT_ACCOUNT_BALANCE_FOR_TESTS: u128 = 10;
+
 #[tokio::test]
 async fn test_migration_access_right() {
     let contract = TestContract::new().await.unwrap();
-    let data = MigrationInputData::default();
+    let accounts: Vec<String> = vec![];
     let user_acc = contract.contract_account("any").await.unwrap();
     let res = user_acc
-        .migrate(data)
+        .migrate(accounts)
         .max_gas()
         .transact()
         .await
@@ -23,18 +24,10 @@ async fn test_migration_access_right() {
 #[tokio::test]
 async fn test_migration() {
     let contract = TestContract::new().await.unwrap();
-    let proof_keys = vec![
-            "148209196192531111581487824716711513123053186167982062461521682161284461208612290809"
-                .to_string();
-            1000
-        ];
-    let data = MigrationInputData {
-        used_proofs: proof_keys,
-        ..Default::default()
-    };
+    let accounts = vec!["account1".to_owned()];
     let res = contract
         .contract
-        .migrate(data)
+        .migrate(accounts)
         .max_gas()
         .transact()
         .await
@@ -54,53 +47,17 @@ async fn test_migration_state() {
     let data = std::fs::read("../contract_state.borsh").expect("Test state data not found");
     let state = StateData::try_from_slice(&data).unwrap();
 
-    let limit = 1000;
+    let limit = 750;
     let mut total_gas_burnt = 0;
 
-    // Proofs migration
-    let mut proofs_gas_burnt = 0;
-    let mut proofs_count = 0;
-
-    for proofs in state.proofs.chunks(limit) {
-        proofs_count += proofs.len();
-        let args = MigrationInputData {
-            used_proofs: proofs.to_vec(),
-            ..Default::default()
-        };
-        let res = contract
-            .contract
-            .migrate(args)
-            .max_gas()
-            .transact()
-            .await
-            .unwrap();
-        assert!(res.is_success());
-        proofs_gas_burnt += res.total_gas_burnt().as_gas();
-        println!(
-            "Proofs: {proofs_count:?} [{:.1} TGas]",
-            to_tera(proofs_gas_burnt)
-        );
-    }
-
-    assert_eq!(proofs_count, state.proofs.len());
-    // INCREASED!
-    //assert!(proofs_gas_burnt as f64 / 1_000_000_000_000. < 5416.1);
-    assert!(to_tera(proofs_gas_burnt) < 10326.0);
-    total_gas_burnt += proofs_gas_burnt;
-    println!();
-
     // Accounts migration
     let accounts_vec = state.accounts.iter().collect::<Vec<_>>();
-    let mut accounts_gas_burnt = 0;
     let mut accounts_count = 0;
 
     for chunk in accounts_vec.chunks(limit) {
         accounts_count += chunk.len();
+        let args = chunk.iter().map(|i| i.0.to_string()).collect();
 
-        let args = MigrationInputData {
-            accounts: vec_to_map(chunk),
-            ..Default::default()
-        };
         let res = contract
             .contract
             .migrate(args)
@@ -109,11 +66,11 @@ async fn test_migration_state() {
             .await
             .unwrap();
         assert!(res.is_success());
-        accounts_gas_burnt += res.total_gas_burnt().as_gas();
+        total_gas_burnt += res.total_gas_burnt().as_gas();
 
         println!(
             "Accounts: {accounts_count:?} [{:.1} TGas]",
-            to_tera(accounts_gas_burnt)
+            to_tera(total_gas_burnt)
         );
     }
     assert_eq!(state.accounts.len(), accounts_count);
@@ -122,33 +79,6 @@ async fn test_migration_state() {
     // println!("\n{:?}", accounts_gas_burnt);
     // INCREASED!
     // assert!(accounts_gas_burnt as f64 / 1_000_000_000_000. < 1520.);
-    assert!(
-        to_tera(accounts_gas_burnt) < 1992.,
-        "{:?} < {:?}",
-        to_tera(accounts_gas_burnt),
-        1992.
-    );
-    total_gas_burnt += accounts_gas_burnt;
-
-    // Migrate Contract data
-    let args = MigrationInputData {
-        total_supply: Some(state.contract_data.total_eth_supply_on_near.as_u128()),
-        account_storage_usage: Some(state.contract_data.account_storage_usage),
-        ..Default::default()
-    };
-    let res = contract
-        .contract
-        .migrate(args)
-        .max_gas()
-        .transact()
-        .await
-        .unwrap();
-    assert!(res.is_success());
-    total_gas_burnt += res.total_gas_burnt().as_gas();
-    // INCREASED!
-    //assert!(total_gas_burnt as f64 / 1_000_000_000_000. < 6878.6);
-    // INCREASED!
-    //assert!(total_gas_burnt as f64 / 1_000_000_000_000. < 11852.6);
     println!("\n{total_gas_burnt:?}");
     assert!(
         to_tera(total_gas_burnt) < 12315.,
@@ -165,9 +95,8 @@ async fn test_migration_state() {
 
     // Check basic (NEP-141) contract data
     let args = MigrationInputData {
-        total_supply: Some(state.contract_data.total_eth_supply_on_near.as_u128()),
-        account_storage_usage: Some(state.contract_data.account_storage_usage),
-        ..Default::default()
+        total_supply: Some(accounts_count as u128 * DEFAULT_ACCOUNT_BALANCE_FOR_TESTS),
+        accounts: HashMap::default(),
     };
     let res = contract
         .contract
@@ -177,33 +106,24 @@ async fn test_migration_state() {
         .result;
     assert_eq!(res, MigrationCheckResult::Success);
 
-    // Check proofs data
-    proofs_count = 0;
-    for proofs in state.proofs.chunks(limit) {
-        proofs_count += proofs.len();
-        let args = MigrationInputData {
-            used_proofs: proofs.to_vec(),
-            ..Default::default()
-        };
-        let res = contract
-            .contract
-            .check_migration_correctness(args)
-            .await
-            .unwrap()
-            .result;
-        assert_eq!(res, MigrationCheckResult::Success);
-
-        println!("Proofs checked: [{proofs_count:?}]");
-    }
-
     // Check accounts data
     accounts_count = 0;
     for chunk in accounts_vec.chunks(limit) {
         accounts_count += chunk.len();
 
+        let accounts = chunk
+            .iter()
+            .map(|(a, _)| {
+                (
+                    AccountId::from_str(a.as_str()).unwrap(),
+                    DEFAULT_ACCOUNT_BALANCE_FOR_TESTS,
+                )
+            })
+            .collect();
+
         let args = MigrationInputData {
-            accounts: vec_to_map(chunk),
-            ..Default::default()
+            accounts,
+            total_supply: None,
         };
         let res = contract
             .contract
@@ -220,14 +140,3 @@ async fn test_migration_state() {
 fn to_tera(gas: u64) -> f64 {
     gas as f64 / 1_000_000_000_000.
 }
-
-fn vec_to_map(vec: &[(&near_sdk::AccountId, &NEP141Wei)]) -> HashMap<AccountId, Balance> {
-    vec.iter()
-        .map(|(a, b)| {
-            (
-                AccountId::from_str((*a).clone().as_str()).unwrap(),
-                b.as_u128(),
-            )
-        })
-        .collect()
-}
diff --git a/eth-connector/src/connector.rs b/eth-connector/src/connector.rs
@@ -1,5 +1,5 @@
 use crate::{connector_impl::FinishDepositCallArgs, Proof, VerifyProofArgs, WithdrawResult};
-use aurora_engine_types::types::Address;
+use aurora_engine_types::types::{Address, NEP141Wei};
 use near_contract_standards::storage_management::StorageBalance;
 use near_sdk::{
     borsh, ext_contract, json_types::U128, AccountId, Balance, Promise, PromiseOrValue,
@@ -37,6 +37,16 @@ pub trait ProofVerifier {
     fn verify_log_entry_in_bound(&self, #[serializer(borsh)] args: VerifyProofArgs) -> bool;
 }
 
+#[ext_contract(ext_migrate)]
+pub trait Migrate {
+    fn migrate_callback(
+        &mut self,
+        #[callback]
+        #[serializer(borsh)]
+        balances: aurora_engine_types::HashMap<AccountId, NEP141Wei>,
+    );
+}
+
 /// Withdraw method for legacy implementation in Engine
 #[ext_contract(ext_engine_withdraw)]
 pub trait EngineConnectorWithdraw {
@@ -70,6 +80,15 @@ pub trait EngineFungibleToken {
     ) -> PromiseOrValue<U128>;
 }
 
+#[ext_contract(ext_engine_connector)]
+pub trait EngineConnector {
+    #[result_serializer(borsh)]
+    fn ft_balances_of(
+        &mut self,
+        #[serializer(borsh)] accounts: Vec<AccountId>,
+    ) -> std::collections::HashMap<AccountId, Balance>;
+}
+
 /// Engin compatible methods for NEP-141
 #[ext_contract(ext_engine_storage)]
 pub trait EngineStorageManagement {