Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Elixir v1.15 #115

Merged
merged 4 commits into from
May 17, 2024
Merged

Compatibility with Elixir v1.15 #115

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
002c231
Use static list instead of Logger.levels/0
kbredemeier May 16, 2024
39ef069
Changes required elixir version to v1.15.1
kbredemeier May 16, 2024
882da48
Adds elixir v1.15.1 to CI matrix
kbredemeier May 17, 2024
cfe0258
Update mix.exs
AndrewDryga May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jobs:
include:
- otp-version: 24.3
elixir-version: 1.16
- otp-version: 25
elixir-version: 1.15.1
- otp-version: 25
elixir-version: 1.16
check-formatted: true
Expand Down
2 changes: 1 addition & 1 deletion lib/logger_json.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ defmodule LoggerJSON do
* `:conn` - the `Plug.Conn` struct. This is useful when logging HTTP requests and responses,
each formatter may use it differently.
"""
@log_levels Logger.levels()
@log_levels [:error, :info, :debug, :emergency, :alert, :critical, :warning, :notice]
@log_level_strings Enum.map(@log_levels, &to_string/1)

@doc """
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ defmodule LoggerJSON.Mixfile do
[
app: :logger_json,
version: @version,
elixir: "~> 1.16",
elixir: "~> 1.15.1",
Copy link
Member

@AndrewDryga AndrewDryga May 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make it work only on 1.15.X so what we really want is ~> 1.16 or ~> 1.15.1. I will fix it up after the merge so no worries about that.

elixirc_paths: elixirc_paths(Mix.env()),
compilers: [] ++ Mix.compilers(),
build_embedded: Mix.env() == :prod,
Expand Down
Loading