Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NHSU CR-302 MIS BLOCKER EMAIL VALIDATOR OF ENTIRE EHCS #17

Closed
wants to merge 6 commits into from

Conversation

5HT
Copy link

@5HT 5HT commented May 20, 2024

Greetings TWIMC!

On behalf of Ukrainian State Enterprise "Elektronne Zdorovya" I want to inform you can EMAIL validator presented in this package is used in @edenlablcc/schemata EHCS dependency in core application. The CR-302 ticket is a blocker for Ukrainian Medical Information Systems to register email that has gTLD more that 3 letters which is not only violation of RFC 822 but also naive and improper.

The problem is that EHCS is built up based on HEX.PM dependency in schemata:

 {:nex_json_schema, "~> 0.8.6"}

You either should accept the following change:

- @email_regex ~r<^[\w!#$%&'*+/=?`{|}~^-]+(?:\.[\w!#$%&'*+/=?`{|}~^-]+)*@(?:[A-Z0-9-]+\.)+[A-Z]{2,6}$>i
+ @email_regex ~r<^[\w!#$%&'*+/=?`{|}~^-]+(?:\.[\w!#$%&'*+/=?`{|}~^-]+)*@(?:[A-Z0-9-]+\.)+[A-Z]{2,63}$>i

in lib/ex_json_schema/validator/format.ex.

But overall the https://hex.pm/packages/nex_json_schema packages should be replaced with
https://hex.pm/packages/nex_json_schema2 that hosts on NHSU Github. The duplicated message as separate merge will be requested at edenlabllc/schemata repository:

- {:nex_json_schema, "~> 0.8.6"}
+ {:nex_json_schema2, "~> 0.8.7"}

@coveralls
Copy link

Coverage Status

coverage: 98.031% (-0.4%) from 98.419%
when pulling 307a155 on ehealth-ua:master
into 2e3a124 on Nebo15:master.

@5HT 5HT closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants