Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Aqua to 0.8 and use more defaults #1500

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Conversation

lgoettgens
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e578d4a) 86.73% compared to head (3b825aa) 86.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files         111      111           
  Lines       28833    28833           
=======================================
  Hits        25009    25009           
  Misses       3824     3824           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens marked this pull request as draft November 16, 2023 11:14
@fingolfin
Copy link
Member

Any idea why it fails with Julia 1.10?

@lgoettgens
Copy link
Collaborator Author

Yep, JuliaTesting/Aqua.jl#240 should fix it. Currently waiting for the 0.8.1 release

@lgoettgens lgoettgens marked this pull request as ready for review November 16, 2023 14:16
@fingolfin fingolfin merged commit d07fa23 into Nemocas:master Nov 17, 2023
15 checks passed
@lgoettgens lgoettgens deleted the lg/aqua branch November 17, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants