Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move code from Oscar.jl/experimental/GModule/Misc.jl here #1675

Merged
merged 5 commits into from
Apr 25, 2024
Merged

move code from Oscar.jl/experimental/GModule/Misc.jl here #1675

merged 5 commits into from
Apr 25, 2024

Commits on Apr 17, 2024

  1. move code from Oscar.jl/experimental/GModule/Misc.jl here 

    The idea is to add this code to AbstractAlgebra.jl,
and then to remove it from Oscar.jl.

Once we agree what shall be really added here,
tests and documentation has to be added.
(I am quite sure that I have put certain parts into the wrong files,
and that some functions have to be changed.)
    @ThomasBreuer
    ThomasBreuer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    902682a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. remove a method: will the test failures disappear? 

    I do not understand what is happening here:
Installing a `matrix(phi::IdentityMap{<:AbstractAlgebra.FPModule})` method
seems to make another `matrix` method unavailable?
    @ThomasBreuer
    ThomasBreuer committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1780be1 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. fix the new matrix method

    @ThomasBreuer
    ThomasBreuer committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    894cfe2 View commit details
    Browse the repository at this point in the history

  2. rename direct_sum to hom, as suggested

    @ThomasBreuer
    ThomasBreuer committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6f71ea2 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Apply suggestions from code review

    @fingolfin
    fingolfin authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7965826 View commit details
    Browse the repository at this point in the history