Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set! for finite field elements #1908

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Oct 18, 2024

ping @fingolfin to not work on the same thing

@lgoettgens lgoettgens marked this pull request as draft October 18, 2024 15:32
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 80.85106% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.20%. Comparing base (633112d) to head (c59c1f9).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/fq.jl 66.66% 5 Missing ⚠️
src/flint/fq_default.jl 85.71% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   87.24%   87.20%   -0.04%     
==========================================
  Files          97       97              
  Lines       35590    35589       -1     
==========================================
- Hits        31049    31035      -14     
- Misses       4541     4554      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens force-pushed the lg/fq-set! branch 2 times, most recently from ead8b7e to c59c1f9 Compare October 18, 2024 16:04
@lgoettgens lgoettgens marked this pull request as ready for review October 18, 2024 16:09
@fingolfin fingolfin merged commit a834677 into Nemocas:master Oct 28, 2024
23 of 25 checks passed
@lgoettgens lgoettgens deleted the lg/fq-set! branch October 28, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants