Use _arb_set/_acb_set instead of ccall
#1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/arb-acb-set--ccalls
branch
from
440cdb4
to
57a5118
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1912 +/- ##
==========================================
+ Coverage 87.24% 87.25% +0.01%
==========================================
Files 97 97
Lines 35590 35606 +16
==========================================
+ Hits 31049 31068 +19
+ Misses 4541 4538 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat orthogonal to #1909. Instead of changing
_arb_set, this PR instead changes all call-sites of the corresponding FLINT-functions to instead call_arb_set.This is part of the effort to only call FLINT from few dedicated functions.