Don't use ccalls where wrappers already exist (fmpz edition) #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/less-ccalls-fmpz
branch
from
adb3836
to
5655206
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1913 +/- ##
==========================================
+ Coverage 87.22% 87.39% +0.17%
==========================================
Files 97 97
Lines 35556 35539 -17
==========================================
+ Hits 31014 31061 +47
+ Misses 4542 4478 -64 ☔ View full report in Codecov by Sentry. |
lgoettgens
force-pushed
the
lg/less-ccalls-fmpz
branch
from
5655206
to
4533873
Compare
fingolfin
approved these changes
Oct 24, 2024
fingolfin
reviewed
Oct 24, 2024
| @@ -158,8 +158,7 @@ end | |||
| @boundscheck _checkbounds(A, i, j) | |||
| GC.@preserve A begin | |||
| m = mat_entry_ptr(A, i, j) | |||
| fl = ccall((:fmpz_sgn, libflint), Int, (Ptr{ZZRingElem},), m) | |||
| return isone(fl) | |||
| return is_positive(m) | |||
There was a problem hiding this comment.
Code not covered, seems we have zero tests for is_positive_entry :-(
fingolfin
reviewed
Oct 24, 2024
| nr = ccall((:fmpq_numerator_ptr, libflint), Ptr{ZZRingElem}, (Ref{QQFieldElem},), a) | ||
| vn = ccall((:fmpz_remove, libflint), Clong, (Ptr{ZZRingElem}, Ptr{ZZRingElem}, Ref{ZZRingElem}), nr, nr, b) | ||
| nr = _num_ptr(a) | ||
| vn, nr = remove!(nr, b) |
There was a problem hiding this comment.
Code not covered, seems we have zero tests for remove! :-(
|
I added a bunch of minor tests :-) |
fingolfin
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.