Wrap Arb pointer functions into julia functions #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
changed the title
acb_real_ptr and acb_imag_ptr into functions
lgoettgens
force-pushed
the
lg/real-imag-ptr
branch
from
2ddf025
to
3de8b95
Compare
|
Fine by me. My recommendation: Don't get distract by trying to cover all cases perfectly. Having 80% in now beats having 100% in with 2 days of work :-) |
|
This now should be everything (TM). Everything else that does not have an easy fix will get reverted |
lgoettgens
force-pushed
the
lg/real-imag-ptr
branch
from
e115f31
to
36ef525
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
- Coverage 87.44% 87.42% -0.03%
==========================================
Files 97 97
Lines 35555 35626 +71
==========================================
+ Hits 31092 31146 +54
- Misses 4463 4480 +17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some trivial changes from #1909 (it has conflicts due to #1912 anyway) and more in the same direction.