Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change _acb_set to take real and imag part as tuple #1928

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

lgoettgens
Copy link
Collaborator

As suggested in #1909 (comment)

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 24 lines in your changes missing coverage. Please review.

Project coverage is 87.38%. Comparing base (13e29a5) to head (4dcf522).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/arb/ArbTypes.jl 20.00% 8 Missing ⚠️
src/arb/Complex.jl 46.15% 7 Missing ⚠️
src/arb/acb.jl 46.15% 7 Missing ⚠️
src/arb/ComplexMat.jl 0.00% 1 Missing ⚠️
src/arb/acb_mat.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1928      +/-   ##
==========================================
- Coverage   87.39%   87.38%   -0.01%     
==========================================
  Files          97       97              
  Lines       35642    35642              
==========================================
- Hits        31149    31147       -2     
- Misses       4493     4495       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin fingolfin merged commit 2de7b3a into Nemocas:master Oct 27, 2024
22 of 24 checks passed
@lgoettgens lgoettgens deleted the lg/_acb_set-tuple branch October 27, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants