Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some large refactorings to .git-blame-ignore-revs #1936

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

lgoettgens
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (3286337) to head (75e94e6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1936      +/-   ##
==========================================
- Coverage   87.51%   87.46%   -0.06%     
==========================================
  Files          97       97              
  Lines       35537    35537              
==========================================
- Hits        31101    31083      -18     
- Misses       4436     4454      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.git-blame-ignore-revs Outdated Show resolved Hide resolved
# The big renaming
6950b14829d4cc747d9d7d90335ebc0d1fe283fc
80cdca476750a641c991e1c0a891936bfc5321c5
387c48ca6e4eda31841b8f58a8361e44137f2592
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are the hashes from the pull request, but not the ones the corresponding commits on master have. 😅

> git show 387c48ca6e4eda31841b8f58a8361e44137f2592
Schwerwiegend: bad object 387c48ca6e4eda31841b8f58a8361e44137f2592

This one should be 0adcc7e I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah... You're right. I'll follow up next week

Copy link
Collaborator

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@lgoettgens lgoettgens merged commit 2406122 into Nemocas:master Nov 4, 2024
23 of 24 checks passed
@lgoettgens lgoettgens deleted the lg/git-blame-ignore-revs branch November 4, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants