Headers refactoring in ONNX importer (#4004)

NervanaSystems · Dec 6, 2019 · 9b56d08 · 9b56d08
1 parent eb2ce8e
commit 9b56d08
Show file tree

Hide file tree

Showing 63 changed files with 88 additions and 71 deletions.
diff --git a/src/ngraph/frontend/onnx_import/CMakeLists.txt b/src/ngraph/frontend/onnx_import/CMakeLists.txt
@@ -164,7 +164,7 @@ add_library(onnx_import STATIC
         op/reshape.cpp
         op/reshape.hpp
         op/reverse_sequence.cpp
-        op/reverse_sequence.h
+        op/reverse_sequence.hpp
         op/selu.cpp
         op/selu.hpp
         op/shape.hpp

diff --git a/src/ngraph/frontend/onnx_import/op/acosh.cpp b/src/ngraph/frontend/onnx_import/op/acosh.cpp
@@ -14,6 +14,8 @@
 // limitations under the License.
 //*****************************************************************************
 
+#include <memory>
+
 #include "acosh.hpp"
 #include "ngraph/op/add.hpp"
 #include "ngraph/op/constant.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/acosh.hpp b/src/ngraph/frontend/onnx_import/op/acosh.hpp
@@ -16,8 +16,6 @@
 
 #pragma once
 
-#include <memory>
-
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 

diff --git a/src/ngraph/frontend/onnx_import/op/add.hpp b/src/ngraph/frontend/onnx_import/op/add.hpp
@@ -16,6 +16,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/add.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/and.hpp b/src/ngraph/frontend/onnx_import/op/and.hpp
@@ -16,6 +16,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/and.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/argmax.cpp b/src/ngraph/frontend/onnx_import/op/argmax.cpp
@@ -14,9 +14,10 @@
 // limitations under the License.
 //*****************************************************************************
 
-#include "ngraph/op/argmax.hpp"
+#include "argmax.hpp"
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
+#include "ngraph/op/argmax.hpp"
 #include "utils/reduction.hpp"
 
 namespace ngraph

diff --git a/src/ngraph/frontend/onnx_import/op/argmin.cpp b/src/ngraph/frontend/onnx_import/op/argmin.cpp
@@ -14,9 +14,10 @@
 // limitations under the License.
 //*****************************************************************************
 
-#include "ngraph/op/argmin.hpp"
+#include "argmin.hpp"
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
+#include "ngraph/op/argmin.hpp"
 #include "utils/reduction.hpp"
 
 namespace ngraph

diff --git a/src/ngraph/frontend/onnx_import/op/asinh.cpp b/src/ngraph/frontend/onnx_import/op/asinh.cpp
@@ -14,6 +14,8 @@
 // limitations under the License.
 //*****************************************************************************
 
+#include <memory>
+
 #include "asinh.hpp"
 #include "ngraph/op/add.hpp"
 #include "ngraph/op/constant.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/asinh.hpp b/src/ngraph/frontend/onnx_import/op/asinh.hpp
@@ -16,8 +16,6 @@
 
 #pragma once
 
-#include <memory>
-
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 

diff --git a/src/ngraph/frontend/onnx_import/op/atanh.cpp b/src/ngraph/frontend/onnx_import/op/atanh.cpp
@@ -14,6 +14,8 @@
 // limitations under the License.
 //*****************************************************************************
 
+#include <memory>
+
 #include "atanh.hpp"
 #include "ngraph/op/add.hpp"
 #include "ngraph/op/constant.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/atanh.hpp b/src/ngraph/frontend/onnx_import/op/atanh.hpp
@@ -16,8 +16,6 @@
 
 #pragma once
 
-#include <memory>
-
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 

diff --git a/src/ngraph/frontend/onnx_import/op/average_pool.cpp b/src/ngraph/frontend/onnx_import/op/average_pool.cpp
@@ -14,6 +14,7 @@
 // limitations under the License.
 //*****************************************************************************
 
+#include "average_pool.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/avg_pool.hpp"
 #include "utils/pooling_factory.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/batch_norm.cpp b/src/ngraph/frontend/onnx_import/op/batch_norm.cpp
@@ -17,10 +17,9 @@
 #include <cstdint>
 #include <memory>
 
-#include "ngraph/frontend/onnx_import/core/null_node.hpp"
-#include "ngraph/frontend/onnx_import/exceptions.hpp"
-#include "ngraph/frontend/onnx_import/op/batch_norm.hpp"
-#include "ngraph/node.hpp"
+#include "batch_norm.hpp"
+#include "core/null_node.hpp"
+#include "exceptions.hpp"
 #include "ngraph/op/batch_norm.hpp"
 
 namespace ngraph

diff --git a/src/ngraph/frontend/onnx_import/op/batch_norm.hpp b/src/ngraph/frontend/onnx_import/op/batch_norm.hpp
@@ -17,6 +17,7 @@
 #pragma once
 
 #include "core/node.hpp"
+#include "ngraph/node.hpp"
 
 namespace ngraph
 {

diff --git a/src/ngraph/frontend/onnx_import/op/constant.cpp b/src/ngraph/frontend/onnx_import/op/constant.cpp
@@ -14,10 +14,9 @@
 // limitations under the License.
 //*****************************************************************************
 
-#include "ngraph/op/constant.hpp"
-#include "core/node.hpp"
+#include "constant.hpp"
 #include "core/tensor.hpp"
-#include "ngraph/node.hpp"
+#include "ngraph/op/constant.hpp"
 
 namespace ngraph
 {

diff --git a/src/ngraph/frontend/onnx_import/op/conv.cpp b/src/ngraph/frontend/onnx_import/op/conv.cpp
@@ -18,10 +18,9 @@
 #include <memory>
 #include <vector>
 
+#include "conv.hpp"
+#include "exceptions.hpp"
 #include "ngraph/builder/reshape.hpp"
-#include "ngraph/frontend/onnx_import/exceptions.hpp"
-#include "ngraph/frontend/onnx_import/op/conv.hpp"
-#include "ngraph/frontend/onnx_import/utils/convpool.hpp"
 #include "ngraph/op/add.hpp"
 #include "ngraph/op/broadcast.hpp"
 #include "ngraph/op/concat.hpp"
@@ -31,6 +30,7 @@
 #include "ngraph/op/slice.hpp"
 #include "ngraph/op/util/attr_types.hpp"
 #include "ngraph/op/util/broadcasting.hpp"
+#include "utils/convpool.hpp"
 
 namespace ngraph
 {

diff --git a/src/ngraph/frontend/onnx_import/op/conv_integer.cpp b/src/ngraph/frontend/onnx_import/op/conv_integer.cpp
@@ -14,7 +14,7 @@
 // limitations under the License.
 //*****************************************************************************
 
-#include "op/conv_integer.hpp"
+#include "conv_integer.hpp"
 #include "ngraph/builder/make_constant.hpp"
 #include "ngraph/frontend/onnx_import/exceptions.hpp"
 #include "ngraph/frontend/onnx_import/utils/convpool.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/conv_transpose.cpp b/src/ngraph/frontend/onnx_import/op/conv_transpose.cpp
@@ -20,15 +20,15 @@
 #include <memory>
 #include <vector>
 
+#include "conv_transpose.hpp"
+#include "exceptions.hpp"
 #include "ngraph/coordinate_diff.hpp"
-#include "ngraph/frontend/onnx_import/exceptions.hpp"
-#include "ngraph/frontend/onnx_import/op/conv_transpose.hpp"
-#include "ngraph/frontend/onnx_import/utils/convpool.hpp"
 #include "ngraph/op/add.hpp"
 #include "ngraph/op/fused/group_conv_transpose.hpp"
 #include "ngraph/op/util/attr_types.hpp"
 #include "ngraph/op/util/broadcasting.hpp"
 #include "ngraph/shape.hpp"
+#include "utils/convpool.hpp"
 
 namespace ngraph
 {

diff --git a/src/ngraph/frontend/onnx_import/op/dequantize_linear.cpp b/src/ngraph/frontend/onnx_import/op/dequantize_linear.cpp
@@ -17,12 +17,12 @@
 #include <cstdint>
 #include <memory>
 
+#include "dequantize_linear.hpp"
 #include "ngraph/axis_set.hpp"
 #include "ngraph/builder/make_constant.hpp"
 #include "ngraph/op/convert.hpp"
 #include "ngraph/op/dequantize.hpp"
 #include "ngraph/shape.hpp"
-#include "quantize_linear.hpp"
 
 namespace ngraph
 {

diff --git a/src/ngraph/frontend/onnx_import/op/div.hpp b/src/ngraph/frontend/onnx_import/op/div.hpp
@@ -16,6 +16,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/divide.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/elu.cpp b/src/ngraph/frontend/onnx_import/op/elu.cpp
@@ -17,11 +17,10 @@
 #include <memory>
 #include <vector>
 
+#include "elu.hpp"
 #include "ngraph/op/constant.hpp"
 #include "ngraph/op/fused/elu.hpp"
 
-#include "elu.hpp"
-
 namespace ngraph
 {
     namespace onnx_import

diff --git a/src/ngraph/frontend/onnx_import/op/equal.hpp b/src/ngraph/frontend/onnx_import/op/equal.hpp
@@ -16,6 +16,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/equal.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/expand.cpp b/src/ngraph/frontend/onnx_import/op/expand.cpp
@@ -16,6 +16,7 @@
 
 #include <cstddef>
 #include <cstdint>
+#include <memory>
 
 #include "expand.hpp"
 #include "ngraph/descriptor/output.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/eye_like.cpp b/src/ngraph/frontend/onnx_import/op/eye_like.cpp
@@ -13,9 +13,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 //*****************************************************************************
-#include "eye_like.hpp"
+
+#include <memory>
+
 #include "exceptions.hpp"
-#include "ngraph/frontend/onnx_import/utils/common.hpp"
+#include "eye_like.hpp"
+#include "utils/common.hpp"
 
 namespace ngraph
 {

diff --git a/src/ngraph/frontend/onnx_import/op/flatten.hpp b/src/ngraph/frontend/onnx_import/op/flatten.hpp
@@ -16,8 +16,6 @@
 
 #pragma once
 
-#include <memory>
-
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 

diff --git a/src/ngraph/frontend/onnx_import/op/gather.hpp b/src/ngraph/frontend/onnx_import/op/gather.hpp
@@ -16,6 +16,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/gather.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/global_average_pool.cpp b/src/ngraph/frontend/onnx_import/op/global_average_pool.cpp
@@ -14,6 +14,7 @@
 // limitations under the License.
 //*****************************************************************************
 
+#include "global_average_pool.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/avg_pool.hpp"
 #include "utils/pooling_factory.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/global_max_pool.cpp b/src/ngraph/frontend/onnx_import/op/global_max_pool.cpp
@@ -14,6 +14,7 @@
 // limitations under the License.
 //*****************************************************************************
 
+#include "global_max_pool.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/max_pool.hpp"
 #include "utils/pooling_factory.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/greater.hpp b/src/ngraph/frontend/onnx_import/op/greater.hpp
@@ -16,6 +16,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/greater.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/instance_norm.cpp b/src/ngraph/frontend/onnx_import/op/instance_norm.cpp
@@ -15,6 +15,7 @@
 //*****************************************************************************
 
 #include <cstddef>
+#include <memory>
 
 #include "exceptions.hpp"
 #include "instance_norm.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/leaky_relu.cpp b/src/ngraph/frontend/onnx_import/op/leaky_relu.cpp
@@ -17,17 +17,10 @@
 #include <memory>
 
 #include "exceptions.hpp"
-#include "ngraph/node.hpp"
-#include "ngraph/node.hpp"
-#include "ngraph/op/broadcast.hpp"
+#include "leaky_relu.hpp"
 #include "ngraph/op/constant.hpp"
 #include "ngraph/op/maximum.hpp"
 #include "ngraph/op/multiply.hpp"
-#include "ngraph/shape.hpp"
-
-#include "core/node.hpp"
-#include "leaky_relu.hpp"
-#include "ngraph/op/util/broadcasting.hpp"
 
 namespace ngraph
 {

diff --git a/src/ngraph/frontend/onnx_import/op/less.hpp b/src/ngraph/frontend/onnx_import/op/less.hpp
@@ -16,6 +16,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/less.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/log_softmax.cpp b/src/ngraph/frontend/onnx_import/op/log_softmax.cpp
@@ -16,10 +16,8 @@
 
 #include <memory>
 
-#include "core/node.hpp"
-#include "ngraph/node.hpp"
+#include "log_softmax.hpp"
 #include "ngraph/op/fused/log_softmax.hpp"
-#include "utils/common.hpp"
 
 namespace ngraph
 {

diff --git a/src/ngraph/frontend/onnx_import/op/log_softmax.hpp b/src/ngraph/frontend/onnx_import/op/log_softmax.hpp
@@ -16,8 +16,6 @@
 
 #pragma once
 
-#include <memory>
-
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 

diff --git a/src/ngraph/frontend/onnx_import/op/lp_norm.cpp b/src/ngraph/frontend/onnx_import/op/lp_norm.cpp
@@ -16,6 +16,7 @@
 
 #include <cstddef>
 #include <cstdint>
+#include <memory>
 
 #include "exceptions.hpp"
 #include "lp_norm.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/lstm.cpp b/src/ngraph/frontend/onnx_import/op/lstm.cpp
@@ -22,6 +22,7 @@
 #include <vector>
 
 #include "exceptions.hpp"
+#include "lstm.hpp"
 #include "ngraph/builder/split.hpp"
 #include "ngraph/frontend/onnx_import/op/lstm.hpp"
 #include "ngraph/op/add.hpp"

diff --git a/src/ngraph/frontend/onnx_import/op/matmul.hpp b/src/ngraph/frontend/onnx_import/op/matmul.hpp
@@ -16,6 +16,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "core/node.hpp"
 #include "ngraph/node.hpp"
 #include "ngraph/op/fused/matmul.hpp"