Include NetFabric.CodeAnalysis

[robinvanpoppel]

Hi,

I want to mention that I do not have any experience with nuget packages that have dependencies. I quickly tried to fix the issue myself.

The dependency on NetFabric.CodeAnalysis is lost due the use of SuppressDependenciesWhenPacking. When setting that to true the dependency will appear in the .nupkg. There is a separate project for the file creating the package, but that package id is the same as the project where the analyzers are living in. The $(MSBuildProjectFile)* was throwing an error, so I changed that to Dummy. Because there are two projects however the Package will also consider the referenced project as a dependency of the nuget package which is not ok. I did briefly explore the possibility to merge the contents of the .Package. together with the actual analyzers project but this would be a huge refactor.

Instead I came up with this workaround:

• CopyLocalLockFileAssemblies will copy a number of assemblies to the bin directory of the package. It seems a bit ugly, but that seems to work.
• Include NetFabric.CodeAnalysis in the package (via TfmSpecificPackageFile)
• Rectify the build error on PackageId containing invalid characters (*$(MSBuildProjectFile)*)

This should hopefully fix #73

[aalmada]

@robinvanpoppel Thanks you so much for this PR!