Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visually indicate when a plot has invalid code #308

Open
TheBizzle opened this issue Aug 17, 2015 · 4 comments
Open

Visually indicate when a plot has invalid code #308

TheBizzle opened this issue Aug 17, 2015 · 4 comments

Comments

@TheBizzle
Copy link
Member

When you click a button that contains bad code (including prims that don't yet compile), they don't indicate that they're invalid, and they throw an error on use. Instead, they should be unclickable, and they should show specifically that the code is invalid (like how the text gets red in JVM NetLogo).

@TheBizzle TheBizzle added this to the Tortoise 1.1 milestone Aug 17, 2015
@nicolaspayette
Copy link
Member

Plots with non-compilable code should probably give some visual indication of that too.

@TheBizzle
Copy link
Member Author

Agreed. I wasn't clear about this when I originally wrote the ticket, but any widget with invalid code (slider, plot, button, monitor, chooser) should be shown as broken.

@qiemem qiemem self-assigned this Sep 10, 2015
@TheBizzle
Copy link
Member Author

With the introduction of c435db9, this issue has been solved for all widgets but plots.

@LaCuneta LaCuneta changed the title Visually indicate when a widget has invalid code Visually indicate when a plot has invalid code Feb 19, 2018
@LaCuneta
Copy link
Contributor

LaCuneta commented Jun 5, 2024

If a plot has a runtime error it is squelched in the runWithErrorHandling() method from set-up-widgets.coffee to avoid interrupting the model. It should be displayed to the user in some non-intrusive way as it would be in NetLogo desktop. This is slightly different than the compile time error display, but I think it makes sense to address both at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants