Raise error message from SOAP response when initialize action fails #601
+26
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error handling approach of the initalize action is to raise a generic failure message.
For example:
NetSuite::Records::ItemReceipt.initialize with #<NetSuite::Records::PurchaseOrder:0x00007f561d8717c8> failed.
This does not provide any of the useful context from the SOAP response XML which would be more helpful for debugging the issue.
For example:
Support for fetching error context from the SOAP response XML has been added to other actions, for example:
Adding similar support to the initialize action, and using the message of the first error in the SOAP XML for the InitializationError raise, would provide more useful error context for debugging.