Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle string field names in CustomFieldList#respond_to? #606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle string field names in CustomFieldList#respond_to? #606

wants to merge 1 commit into from

Commits on Mar 6, 2024

  1. Handle string field names in CustomFieldList#respond_to? 

    Previously `respond_to?` assumed it was given a symbol argument, so it
directly checked for that argument in the fields, which are force-keyed
as symbols. If you passed it a string argument, it wouldn't find the
corresponding field, impying it didn't respond to such a method.

Now, the argument is explicitly cast to a symbol before checking if such
a field exists, supporting checking `respond_to?` with both argument
types.
    @cgunther
    cgunther committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    83584cc View commit details
    Browse the repository at this point in the history