-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.4] meson: Add option to override system WolfSSL with embedded WolfSSL #1175
Conversation
@@ -548,6 +548,7 @@ message('BDB version: ', bdb_version) | |||
# | |||
|
|||
have_embedded_ssl = get_option('with-embedded-ssl') | |||
force_embedded_ssl = get_option('with-ssl-override') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I'm overlooking an obvious constraint, but can't with-embedded-ssl
be used as the "forcing" option?
Or conversely, is there a reason to keep with-embedded-ssl
when introducing with-ssl-override
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with-embedded-ssl
is enabled by default. If a correctly configured wolfssl package is detected then with-embedded-ssl
has to be disabled to prevent linking issues. So if we wish to override native wolfssl we have to have a separate option which overrides both...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think get it now. The with-embedded-ssl
option effectively functions as a flag for whether a functional system library was found or not.
bfce06e
to
b6620f6
Compare
Quality Gate passedIssues Measures |
No description provided.