-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use external SSL dependency to provide cast header #1186
Conversation
c02ef5f
to
2ca1a5e
Compare
@rdmark, this provides a workaround until we have a better alternative. Working on it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are you happy with the Sonarcloud static analysis warning? |
It seems fine. It's just warning that CAST functions are deprecated in OpenSSL3, from what I can see. |
@dgsga I can't get this to work in my Debian 12 VM. The resulting DHX UAM doesn't work for auth with either OS9 or macOS... I may be missing something obvious though! |
A longer term solution might be to use the CAST functions in libgcrypt. The license is compatible and its already a dependency. |
Great minds think alike... |
@rdmark, tested login and file transfer on my Bookworm VM with OS9 client and all is well. Have you pulled the latest force commit for the branch? |
My problem was fixed by installing a fresh AppleShare Client 3.8.8 from the Mac Garden. Not sure what happened to the stock extension. |
@dgsga With this solution, I think we need a check in Meson for openssl/libressl when building with bundled SSL. Otherwise you get compile errors like
Also, the Dockerfile needs to be updated as well to add openssl and openssl-dev. As a side note: For some reason Alpine's libressl ships with libcrypto.so.3 while netatalk expects libcrypto.so.52 at runtime ... so while you can link with it, the library cannot be found so DHX won't work. |
Good point, fixed. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
No description provided.