Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the PropertyTest.test into testPropertyValuesUpdateAndEffect and testServiceInitializationWithDefaultProperties #715

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Codegass
Copy link
Contributor

Fix #714

Description

Refactored PropertyTest to split the combined test() method into two distinct tests: testServiceInitializationWithDefaultProperties and testPropertyValuesUpdateAndEffect. This change improves test clarity by isolating specific behaviors into separate tests.

Key Changes

  • Removed test() method to avoid redundancy.
  • Added testServiceInitializationWithDefaultProperties to test service initialization with default settings.
  • Added testPropertyValuesUpdateAndEffect to test the behavior upon updating property values.

…d testServiceInitializationWithDefaultProperties
@rgallardo-netflix rgallardo-netflix merged commit 25fccb7 into Netflix:2.x Mar 26, 2024
5 checks passed
@rgallardo-netflix
Copy link
Contributor

Thank you for these improvements :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor PropertyTest.test() to Improve Test Experience
2 participants