Small fixes for collection types in configuration proxies: #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rgallardo-netflix
commented
May 21, 2024
rgallardo-netflix
commented
- Enable usage of the @DefaultValue annotation for methods with collection return types. Fixes: ConfigProxyFactory support @DefaultValue for Collections #491
- Enable usage of collection types in parametrized properties. Fixes: Add support for returning collections in parameterized properties #681
* Enable usage of the @DefaultValue annotation for methods with collection return types. Fixes: #491 * Enable usage of collection types in parametrized properties. Fixes: #681
# Conflicts: # archaius2-core/src/test/java/com/netflix/archaius/ProxyFactoryTest.java
…ifferent JDKs. Since we don't actually care about the details of the output, lets relax the test.
akang31
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.