From ad943f3a18635dae546aac310fb0246df4c39b2a Mon Sep 17 00:00:00 2001 From: brharrington Date: Sun, 13 Oct 2024 17:22:27 -0500 Subject: [PATCH] core: avoid long conversion for percentiles (#1704) Update percentiles operator to use double values directly rather than coverting to long. --- .../com/netflix/atlas/core/model/MathExpr.scala | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala index a3c90dc8c..380cd6034 100644 --- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala +++ b/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala @@ -892,7 +892,7 @@ object MathExpr { } // Count for each bucket - val counts = new Array[Long](PercentileBuckets.length()) + val counts = new Array[Double](PercentileBuckets.length()) val byBucket = filtered.groupBy { t => // Value should have a prefix of T or D, followed by 4 digit hex integer indicating the // bucket index @@ -920,10 +920,6 @@ object MathExpr { // Array percentile results will get written to val results = new Array[Double](pcts.length) - // Inputs are counters reported as a rate per second. We need to convert to a rate per - // step to get the correct counts for the estimation. - val multiple = context.step / 1000.0 - // If the input was a timer the unit for the buckets is nanoseconds. The type is reflected // by the prefix of T on the bucket key. After estimating the value we multiply by 1e-9 to // keep the result in a base unit of seconds. @@ -937,9 +933,9 @@ object MathExpr { // Fill in the counts for this interval and compute the estimate var j = 0 while (j < usedCounts.length) { - // Note, NaN.toLong == 0, so NaN values are the same as 0 for the count estimate - val v = (bounded(j).data(i) * multiple).toLong - counts(usedCounts(j)) = v + val v = bounded(j).data(i) + if (v.isFinite) + counts(usedCounts(j)) = v j += 1 } PercentileBuckets.percentiles(counts, pcts, results)