core: improve expr.toString performance #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a string from the expression can be a common operation when creating messages. This change reduces the overhead by allowing it to be written to an existing builder instance and reduce the amount of internal resizing and copies. **Before** ``` Benchmark Mode Cnt Score Error Units withEscapes thrpt 10 581,213.514 ± 4708.897 ops/s withNoEscapes thrpt 10 643,706.596 ± 9144.301 ops/s ``` **After** ``` Benchmark Mode Cnt Score Error Units withEscapes thrpt 10 956,439.595 ± 5243.582 ops/s withNoEscapes thrpt 10 1,031,542.340 ± 25261.261 ops/s ```
brharrington
added a commit
to brharrington/atlas
that referenced
this pull request
Nov 1, 2024
The changes in Netflix#1706 have a bug for percentiles used after a group by where the query clause would get duplicated.
brharrington
added a commit
that referenced
this pull request
Nov 1, 2024
The changes in #1706 have a bug for percentiles used after a group by where the query clause would get duplicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a string from the expression can be a common operation when creating messages. This change reduces the overhead by allowing it to be written to an existing builder instance and reduce the amount of internal resizing and copies.
Before
After