Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant check or wrong statement. #55

Open
Repsay opened this issue Jun 25, 2024 · 0 comments
Open

Redundant check or wrong statement. #55

Repsay opened this issue Jun 25, 2024 · 0 comments

Comments

@Repsay
Copy link

Repsay commented Jun 25, 2024

In the function clean_googlengram the following if statement is used. The statements have no overlap as when tag == "." it would still evaluate to true as tag != "PUNCT". Probably and should be used here.

 if tag != 'PUNCT' or tag != '.' or tag != '':
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

55-redundant-check-or-wrong-statement NetherlandsForensicInstitute/demeuk
1 participant
@Repsay