Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeasurementPair.is_colocated() is specific to a certain data source #32

Open
Rijgersberg opened this issue Jun 28, 2023 · 0 comments
Open

Comments

@Rijgersberg
Copy link
Member

def is_colocated(self):

I have dificulty undertanding this method on MeasurementPair. A MeasurementPair sounds like something quite generic, but its is_colocated()-method is weirdly specific.

  1. It references some CSV in the comment (what CSV? MeasurementPairs could come from any number of sources),
  2. It relies on information in its measurement's extra, which sounds like it should be optional and cannot be relied upon in such a general method.

What's even weirder is that there is a more general is_colocated()-function in the same file, only slightly lower.

@Rijgersberg Rijgersberg added invalid This doesn't seem right and removed invalid This doesn't seem right labels Jun 28, 2023
@Rijgersberg Rijgersberg changed the title MeasurementPair.is_co_located() is weirdly specific to a certain data source MeasurementPair.is_colocated() is weirdly specific to a certain data source Jun 28, 2023
@wowtor wowtor changed the title MeasurementPair.is_colocated() is weirdly specific to a certain data source MeasurementPair.is_colocated() is specific to a certain data source Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant