Remove repeated close host call (#2147)

NethermindEth · Sep 19, 2024 · 4fb5d0f · 4fb5d0f
1 parent f3c885f
commit 4fb5d0f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/p2p/p2p.go b/p2p/p2p.go
@@ -233,7 +233,11 @@ func (s *Service) SubscribePeerConnectednessChanged(ctx context.Context) (<-chan
 
 // Run starts the p2p service. Calling any other function before run is undefined behaviour
 func (s *Service) Run(ctx context.Context) error {
-	defer s.host.Close()
+	defer func() {
+		if err := s.host.Close(); err != nil {
+			s.log.Warnw("Failed to close host", "err", err)
+		}
+	}()
 
 	err := s.dht.Bootstrap(ctx)
 	if err != nil {
@@ -268,7 +272,7 @@ func (s *Service) Run(ctx context.Context) error {
 	if err := s.dht.Close(); err != nil {
 		s.log.Warnw("Failed stopping DHT", "err", err.Error())
 	}
-	return s.host.Close()
+	return nil
 }
 
 func (s *Service) setProtocolHandlers() {