L1->L2 message hashes are 256 bit hashes (#2160)

* refactor: Update Hash message to use Hash256 type * Regenerate spec * refactor: Update MsgHash to use Hash256 type in AdaptReceipt function
NethermindEth · Sep 18, 2024 · d637844 · d637844
1 parent 5c6ffd9
commit d637844
Show file tree

Hide file tree

Showing 5 changed files with 210 additions and 137 deletions.
diff --git a/adapters/core2p2p/receipt.go b/adapters/core2p2p/receipt.go
@@ -27,7 +27,7 @@ func AdaptReceipt(r *core.TransactionReceipt, txn core.Transaction) *spec.Receip
 			Type: &spec.Receipt_L1Handler_{
 				L1Handler: &spec.Receipt_L1Handler{
 					Common:  receiptCommon(r),
-					MsgHash: &spec.Hash{Elements: t.MessageHash()},
+					MsgHash: &spec.Hash256{Elements: t.MessageHash()},
 				},
 			},
 		}

diff --git a/p2p/starknet/p2p/proto/common.proto b/p2p/starknet/p2p/proto/common.proto
@@ -6,10 +6,17 @@ message Felt252 {
     bytes elements = 1;
 }
 
+// A hash value representable as a Felt252
 message Hash {
     bytes elements = 1;
 }
 
+// A 256 bit hash value (like Keccak256)
+message Hash256 {
+    // Required to be 32 bytes long
+    bytes elements = 1;
+}
+
 message Hashes {
     repeated Hash items = 1;
 }

diff --git a/p2p/starknet/p2p/proto/receipt.proto b/p2p/starknet/p2p/proto/receipt.proto
@@ -57,7 +57,7 @@ message Receipt {
 
   message L1Handler {
     Common common = 1;
-    Hash msg_hash = 2;
+    Hash256 msg_hash = 2;
   }
 
   message Declare {