Add log encoding option for JSON logging. #2166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows selection of either CONSOLE (the default, and the current behaviour) or JSON for log output, allowing for easier parsing of output for structued log backends.
|
this is a great addition. hope this is merged in soon. curious why you chose to call it encoding, instead of format |
Encoding is the term used internally in the logging. Also, format can be the format for individual fields (e.g. timestamp format) rather than the general encoding of the log entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows selection of either CONSOLE (the default, and the current behaviour) or JSON for log output, allowing for easier parsing of output for structued log backends.