Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(memb-pots): do not validate on addition #191

Merged
merged 1 commit into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions neuroml/nml/helper_methods.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import sys
import re
import sys


#
Expand Down Expand Up @@ -1872,7 +1872,7 @@ def add_membrane_property(self, property_name, **kwargs):

"""
self.setup_nml_cell(use_convention=False)
prop = self.biophysical_properties.membrane_properties.add(property_name, **kwargs)
prop = self.biophysical_properties.membrane_properties.add(property_name, validate=False, **kwargs)
return prop


Expand Down Expand Up @@ -2544,9 +2544,7 @@ def get_morphology_root(self):

inserts = {}

inserts[
"Network"
] = """
inserts["Network"] = """


netGroup = h5file.create_group(h5Group, 'network')
Expand Down Expand Up @@ -2578,9 +2576,7 @@ def get_morphology_root(self):

"""

inserts[
"Population"
] = """
inserts["Population"] = """

popGroup = h5file.create_group(h5Group, 'population_'+self.id)
popGroup._f_setattr("id", self.id)
Expand Down Expand Up @@ -2622,9 +2618,7 @@ def __str__(self):

"""

inserts[
"Projection"
] = """
inserts["Projection"] = """

projGroup = h5file.create_group(h5Group, 'projection_'+self.id)
projGroup._f_setattr("id", self.id)
Expand Down Expand Up @@ -2711,9 +2705,7 @@ def __str__(self):

"""

inserts[
"ElectricalProjection"
] = """
inserts["ElectricalProjection"] = """

projGroup = h5file.create_group(h5Group, 'projection_'+self.id)
projGroup._f_setattr("id", self.id)
Expand Down Expand Up @@ -2786,9 +2778,7 @@ def __str__(self):
"""


inserts[
"ContinuousProjection"
] = """
inserts["ContinuousProjection"] = """

projGroup = h5file.create_group(h5Group, 'projection_'+self.id)
projGroup._f_setattr("id", self.id)
Expand Down Expand Up @@ -2867,9 +2857,7 @@ def __str__(self):
"""


inserts[
"InputList"
] = """
inserts["InputList"] = """

ilGroup = h5file.create_group(h5Group, 'inputList_'+self.id)
ilGroup._f_setattr("id", self.id)
Expand Down
27 changes: 9 additions & 18 deletions neuroml/nml/nml.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# -*- coding: utf-8 -*-

#
# Generated Wed May 8 18:20:27 2024 by generateDS.py version 2.43.3.
# Generated Thu May 30 18:34:59 2024 by generateDS.py version 2.43.3.
# Python 3.11.9 (main, Apr 17 2024, 00:00:00) [GCC 14.0.1 20240411 (Red Hat 14.0.1-0)]
#
# Command line options:
Expand All @@ -28,33 +28,24 @@
ModulenotfoundExp_ = ModuleNotFoundError
except NameError:
ModulenotfoundExp_ = ImportError
from six.moves import zip_longest
import os
import re as re_
import base64
import datetime as datetime_
import decimal as decimal_
from lxml import etree as etree_

import inspect
import math

import os
import re as re_
import typing
from math import pi, sqrt

from operator import attrgetter

import inspect

import natsort
import networkx as nx

import numpy

import natsort

import typing

from lxml import etree as etree_
from six.moves import zip_longest

import neuroml

import neuroml.neuro_lex_ids

Validate_simpletypes_ = True
Expand Down Expand Up @@ -49444,7 +49435,7 @@ def add_membrane_property(self, property_name, **kwargs):
"""
self.setup_nml_cell(use_convention=False)
prop = self.biophysical_properties.membrane_properties.add(
property_name, **kwargs
property_name, validate=False, **kwargs
)
return prop

Expand Down