Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit helper messages regarding neurolexID for neuron export #156

Open
pgleeson opened this issue Jun 8, 2021 · 1 comment
Open

Comments

@pgleeson
Copy link
Member

pgleeson commented Jun 8, 2021

As reported by @MRIO, the usage of neurolexID in segment groups is not very explicit. These are used to determine unbranched segments, which get mapped on to NEURON sections.
https://github.com/NeuroML/org.neuroml.export/blob/development/src/main/java/org/neuroml/export/neuron/JSONCellSerializer.java#L301
https://github.com/OpenSourceBrain/SmithEtAl2013-L23DendriticSpikes/blob/e3ce16fdf368a4a39df4b7b0f15a8f1a8b9ca4dc/NeuroML2/L23_NoHotSpot.cell.nml#L12084

This should be better documented, or very specific error messages thrown.

@pgleeson pgleeson added this to the NeuroML v2.2 release milestone Jun 8, 2021
@MRIO
Copy link

MRIO commented Jun 8, 2021

As background: we commonly had the problem of ion channels not being assigned to segments. When producing executable code this happens completely silently, which endlessly confuses newcomers (and also, some seasoned code writers...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants