Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PinskyRinzel sisat fix #111

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Conversation

JustasB
Copy link

@JustasB JustasB commented Mar 26, 2018

Addresses OpenSourceBrain/PinskyRinzelModel#7 with solution from LEMS/jLEMS#88 (comment)

Without this fix, the abstract cells example fails to compile in NEURON:
https://github.com/NeuroML/NeuroML2/blob/master/examples/NML2_AbstractCells.nml

@pgleeson
Copy link
Member

Thanks @JustasB. Looking into this here: https://github.com/NeuroML/NeuroML2/tree/test_pinrinz

pgleeson added a commit that referenced this pull request Apr 12, 2018
@pgleeson
Copy link
Member

@JustasB did you check this implemetation by running this example in Neuron: https://github.com/NeuroML/NeuroML2/blob/development/LEMSexamples/LEMS_NML2_Ex22_PinskyRinzelCA3.xml?

The mod file compiles, but the simulation fails...

@JustasB
Copy link
Author

JustasB commented Jul 2, 2018

@pgleeson I was able to run the example LEMS in Neuron with a dt of 0.0001 or with CVODE on. I'm attaching the full LEMS file I used. I reduced the simtime to 250ms from 1.5s to keep the .dat file size reasonable.

Take a look,

pinRin.zip

screenshot

My toolchain:

(p27) justas@ubuntu:~/Repositories/pinRin$ jnml -version
 jNeuroML v0.8.3
    org.neuroml.import  v1.5.3
    org.neuroml.export  v1.5.3
    org.neuroml.model   v1.5.3
    jLEMS               v0.9.9.0
(p27) justas@ubuntu:~/Repositories/pinRin$ nrniv
NEURON -- VERSION 7.5 master (6b4c19f) 2017-09-25
Duke, Yale, and the BlueBrain Project -- Copyright 1984-2016
See http://neuron.yale.edu/neuron/credits

loading membrane mechanisms from x86_64/.libs/libnrnmech.so
Additional mechanisms from files
 pr2Atest.mod
oc>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants