Skip to content

Commit

Permalink
fix(sedml): also make data set ids in reports unique
Browse files Browse the repository at this point in the history
Otherwise biosimulations errs with:

```
Multiple objects have the following ids:\n      - time
```
  • Loading branch information
sanjayankur31 committed Apr 18, 2024
1 parent d5aaa32 commit f8a601f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/org/lemsml/export/sedml/SEDMLWriter.java
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ else if(modelFormat == Format.CELLML)
if(ocComp.getTypeName().equals("OutputColumn"))
{
// <dataSet id="d1" name="time" dataReference="time"/>
String ocid = ocComp.getID().replace(" ","_");
String ocid = reportId + "_" + ocComp.getID().replace(" ","_");

String genId = OUTPUT_PREFIX + ofId + "_" + ocid;
startEndElement(main, "dataSet", "id=" + ocid, "name=" + genId, "dataReference=" + genId, "label=" + genId);
Expand Down

0 comments on commit f8a601f

Please sign in to comment.