Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose refactor of I/O class organization #88

Open
oruebel opened this issue Sep 3, 2024 · 1 comment · May be fixed by #85
Open

Propose refactor of I/O class organization #88

oruebel opened this issue Sep 3, 2024 · 1 comment · May be fixed by #85
Labels
category: proposal proposed enhancements or new features priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@oruebel
Copy link
Contributor

oruebel commented Sep 3, 2024

  • BaseIO is growing (in particular with Add data read #85). Also HDF5IO.hpp/cpp are getting long. I propose to refactor the code as follows:
    1. Separate the different classes defined in BaseIO.hpp and HDF5IO.hpp into their own files
    2. Create a new folder src/io with with the classes from BaseIO.hpp
    3. Move the hdf5 folder to src/io/hdf5
@oruebel oruebel added category: proposal proposed enhancements or new features priority: low alternative solution already working and/or relevant to only specific user(s) labels Sep 3, 2024
@oruebel
Copy link
Contributor Author

oruebel commented Sep 3, 2024

@stephprince what do you think?

oruebel added a commit that referenced this issue Sep 5, 2024
@oruebel
Fix #88 move io classes to their own module
99b5d4e
@oruebel oruebel linked a pull request Sep 20, 2024 that will close this issue
Draft
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: proposal proposed enhancements or new features priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add data read NeurodataWithoutBorders/aqnwb
1 participant
@oruebel