Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for duplicate channels and support for appending to an existing ElectrodeTable #94

Open
stephprince opened this issue Sep 11, 2024 · 1 comment
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users

Comments

@stephprince
Copy link
Collaborator

Currently, the API assumes all electrodes have been added and the user cannot add additional channels after the initial ElectrodeTable initialization. To support cases where multiple types of datasets (e.g. ElectricalSeries, SpikeEventSeries) are created from different subsets of electrodes on the ElectrodesTable, we should add support to append additional channels to an existing ElectrodeTable.

To do this, we will need to add checks for duplicate channels. A proposed approach is to:

  1. In ElectrodeTable->addElectrodes(), add a check using the global index/rowIds to only add channels not yet included
  2. In ElectrodeTable->finalize(), if the columns already exist and we have all the data for all of the columns (including custom columns), use an addRow method to append additional channels, otherwise create the columns with all the data.
@stephprince
Copy link
Collaborator Author

Related to: #13

@stephprince stephprince added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

No branches or pull requests

1 participant