Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation]: Special tutorial page on Tables #571

Closed
2 tasks done
bendichter opened this issue Jun 13, 2024 · 1 comment · Fixed by #604
Closed
2 tasks done

[Documentation]: Special tutorial page on Tables #571

bendichter opened this issue Jun 13, 2024 · 1 comment · Fixed by #604
Assignees
@ehennestad
Labels
status: need verification potentially solved, but needs verification topic: docs related to documentation

Comments

@bendichter
Copy link
Contributor

What would you like changed or added to the documentation and why?

Should demonstrate construction modes:

  • conversion from MATLAB table
  • direct declaration
  • addRow

should also cover conversion to Table

Do you have any interest in helping write or edit the documentation?

Yes.

Code of Conduct
@ehennestad ehennestad self-assigned this Sep 17, 2024
ehennestad added a commit that referenced this issue Sep 17, 2024
@ehennestad
Add conversion from table to nwb table in tutorial (Issue #571 )
475866b
@ehennestad ehennestad added topic: docs related to documentation status: need verification potentially solved, but needs verification labels Oct 31, 2024
@ehennestad
Copy link
Collaborator

ehennestad commented Oct 31, 2024 •
edited
Loading

  • Create PR from issue branch with proposed fixes

@ehennestad ehennestad mentioned this issue Oct 31, 2024
Merged
3 tasks
bendichter pushed a commit that referenced this issue Nov 1, 2024
@ehennestad
571 Add "from MATLAB Table" example to Dynamic Tables tutorial (#604)
70fcace 
* Fix: Ensure autogenerated id column is column vector in util.table2nwb

* Add table's variable description to vectordata description property

* Add nwb type descriptions to table's VariableDescription property

* Add conversion from table to nwb table in tutorial (Issue #571 )

* Fix failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehennestad ehennestad

Labels
status: need verification potentially solved, but needs verification topic: docs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

571 Add "from MATLAB Table" example to Dynamic Tables tutorial NeurodataWithoutBorders/matnwb
2 participants
@bendichter @ehennestad