Update load_mat_style.m #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add plot_read_basics to list of tutorials to skip. This tutorial does not produce NWB files that can be read with matnwb.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #602 +/- ##
=======================================
Coverage 90.90% 90.91%
=======================================
Files 107 107
Lines 4751 4753 +2
=======================================
+ Hits 4319 4321 +2
Misses 432 432 ☔ View full report in Codecov by Sentry. |
bendichter
reviewed
Nov 1, 2024
ehennestad
commented
Nov 2, 2024
ehennestad
commented
Nov 2, 2024
ehennestad
commented
Nov 2, 2024
Comment on lines
+49
to
+60
|
|
||
| if isscalar(dataDimensions) | ||
| % Starting in MATLAB R2024b, the input argument for the size | ||
| % of an array in ind2sub must be a vector of positive integers | ||
| % with two or more elements. This fix replicates the behavior of | ||
| % older MATLAB versions, where it was assumed that the a scalar | ||
| % size referred to the row dimension. For scalar dimensions | ||
| % (i.e., row or column vectors), we can still assume this | ||
| % to be true in matnwb. | ||
| dataDimensions = [dataDimensions, 1]; | ||
| end | ||
|
|
There was a problem hiding this comment.
I see what you are saying, yes this is a simpler solution! Good observation
bendichter
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #601
Motivation
Fix issue which arise when loading 1D vectors in MATLAB R2024b due to changes to the
ind2subfunction as described here:https://se.mathworks.com/help/releases/R2024b/matlab/ref/ind2sub.html?searchPort=49569#mw_463053e0-3bc5-40de-88c3-5887f667b5d3
How to test the behavior?
Checklist
fix #XXwhereXXis the issue number?