Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add black formatter to CI #41

Merged
merged 4 commits into from
Oct 13, 2023
Merged

feat: add black formatter to CI #41

merged 4 commits into from
Oct 13, 2023

Conversation

keonly
Copy link
Contributor

@keonly keonly commented Oct 13, 2023

변경 사항

현재 레포지토리는 코드 작성자에 따라 코딩 스타일이 매우 다릅니다. 이 PR은 코드 가독성 및 유지보수성을 개선하기 위해, 코드베이스가 black formatter 가이드라인을 따르도록 Github Actions을 통해 자동화하여 관리합니다.

이 변경으로 모든 Push / PR에서 black formatter를 실행하는 GitHub Actions 워크플로우가 추가됩니다. 이 워크플로우는 rickstaa/action-black@v1 액션을 사용하여 코드베이스에 black formatter를 적용하고, stefanzweifel/git-auto-commit-action@v5 액션을 사용하여 변경 사항을 자동으로 커밋합니다.

기타

로컬에서 black formatter를 적용하는 방법: 링크

This change is needed to ensure that the codebase is formatted
consistently and follows the black formatter guidelines. This will help
improve code readability and maintainability.

This change adds a GitHub Actions workflow that runs the
black formatter on every push and pull request. The workflow uses the
rickstaa/action-black@v1 action to format the codebase and the
stefanzweifel/git-auto-commit-action@v5 action to automatically
commit the changes.

N/A
@keonly
Copy link
Contributor Author

keonly commented Oct 13, 2023

깃헙 레포 설정에서 Workflow permissions에 Read and write permissions가 주어져야 하는데 Read only로 되어 있어서 동작이 안되고 있는 것 같습니다

image

@Re-st
Copy link
Contributor

Re-st commented Oct 13, 2023

네, 바꾸려 하는데 안 되네요. 기다려 주세요
image

@Re-st
Copy link
Contributor

Re-st commented Oct 13, 2023

https://github.com/orgs/community/discussions/57244 로 해결하겠습니다~

@Re-st
Copy link
Contributor

Re-st commented Oct 13, 2023

@Re-st
Copy link
Contributor

Re-st commented Oct 13, 2023

action 잘 돌아가네요~

@Re-st Re-st self-requested a review October 13, 2023 08:04
@Re-st Re-st merged commit 22ea221 into main Oct 13, 2023
@keonly keonly deleted the feat-black-formatter branch November 13, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants