Code Review

[nmontalbanocouncil]

Check for:

• readability
• getting the same results/outputs
• clear methodology

[nmontalbanocouncil]

@romartinez-nycc Overall looks good! Couldn't get some parts to run because of a csv issue, which is noted below.

code/for_carto_map/01_carto_queries.R:

• Comment out this full section and add source('code/00_load_dependencies.R') in script

  street_cleanliness_sept23/code/for_carto_map/01_carto_queries.R

  Line 4 in e9e1e72

  https://data.cityofnewyork.us/resource/erm2-nwe9.csv?$query=SELECT

code/dirty_sidewalk_oath/01_oath_charges.R

• is this the correct csv to read? the subsequent lines of code in the script don't work using this csv

  street_cleanliness_sept23/code/dirty_sidewalk_oath/01_oath_charges.R

  Line 39 in e9e1e72

  cats <- read_csv("data/output/oath_codes/charges_grouped_table.csv")

• what do you mean first time? as in if the csv's don't already exist? would it make sense to run this script if there were new codes or if they changed?

  street_cleanliness_sept23/code/dirty_sidewalk_oath/01_oath_charges.R

  Line 3 in e9e1e72

  # RUN THIS PART ONLY IF ITS THE FIRST TIME !!!

code/dirty_sidewalk_oath/02_oath_eda_cleaning.R

• couldn't run because code/dirty_sidewalk_oath/01_oath_charges.R had errors

code/dirty_sidewalk_oath/03_oath_cats_api_pull.R

• small but you don't need to rep you can just do illegal_dumping$category <- 'Illegal Dumping'
• I didn't know about skim, cool!

  street_cleanliness_sept23/code/dirty_sidewalk_oath/03_oath_cats_api_pull.R

  Line 104 in 9325c2b

  skim(missing_bbl)

• do they get dropped somewhere?

  street_cleanliness_sept23/code/dirty_sidewalk_oath/03_oath_cats_api_pull.R

  Line 106 in 9325c2b

  # drop missing bbls for now

• should this section be moved to the archive folder?

  street_cleanliness_sept23/code/dirty_sidewalk_oath/03_oath_cats_api_pull.R

  Line 110 in 9325c2b

  # CATEGORIES NO LONGER USED - KEEPING FOR FUTURE REFERENCE #######

code/dirty_sidewalk_oath/04_oath_summaries.R

• Works!

code/dirty_sidewalk_oath/05_oath_visuals.R

• should this section be added to archive folder?

  street_cleanliness_sept23/code/dirty_sidewalk_oath/05_oath_visuals.R

  Line 78 in 58cea84

  ## Don't run, not used for webpage --------------

[nmontalbanocouncil]

@rhirotacouncil everything ran and looks good! some small comments on the two scripts below

code/311_committee_requests/01_311_initial_request.Rmd

• Maybe convert this openning paragraph into a more general statement about the purpose of the doc since this will be for the public

  street_cleanliness_sept23/code/311_committee_requests/01_311_initial_request.Rmd

  Line 7 in 58cea84

  Good morning! Here's the 311 data you asked for on street cleanliness (DSNY), illegal dumping (DSNY), derelict vehicles (DSNY), and catch basin complaints (DEP). For catch basin complaints, this includes complaints located at catch basins as well complaints that had 'catch basin' in the complaint description.

• Use source('code/00_load_dependencies.R') instead

  street_cleanliness_sept23/code/311_committee_requests/01_311_initial_request.Rmd

  Line 12 in 58cea84

  library(tidyverse)

• Maybe can remove this if it is just commented out?

  street_cleanliness_sept23/code/311_committee_requests/01_311_initial_request.Rmd

  Line 48 in 58cea84

  # dsny_311 <- dsny_311 %>% filter(created_date >= "2022-08-01" & created_date < "2023-09-01")

• Any reason for using one and not the other?

  street_cleanliness_sept23/code/311_committee_requests/01_311_initial_request.Rmd

  Line 56 in 58cea84

  od_dl <- dsny_311

• Is the old version or new version supposed to be used?

  street_cleanliness_sept23/code/311_committee_requests/01_311_initial_request.Rmd

  Line 60 in 58cea84

  # **NEW VERSION** let's group in a sensible way to reduce categories

• I could be missing it but is there a reason for using dsny_311 here and od_dl above?

  street_cleanliness_sept23/code/311_committee_requests/01_311_initial_request.Rmd

  Line 120 in 58cea84

  dsny_311_id <- dsny_311[dsny_311$complaint_type == "Illegal Dumping",]

code/311_committee_requests/02_311_interactive.R

• Replace with source('code/00_load_dependencies.R')

  street_cleanliness_sept23/code/311_committee_requests/02_311_interactive.R

  Line 1 in 58cea84

  library(tidyverse)

• You can use rbind(df_1, df_2, df_3, df_4) to condense the code

  street_cleanliness_sept23/code/311_committee_requests/02_311_interactive.R

  Lines 68 to 69 in 58cea84

  	df_list <- list(df_1, df_2, df_3, df_4)
  	complaints <- df_list %>% reduce(full_join, by=c('sum', "complaint", "type"))

• Maybe add a link / reference to where this was pulled from so it can be replicated in the future if we forget

  street_cleanliness_sept23/code/311_committee_requests/02_311_interactive.R

  Line 62 in 58cea84

  sum <- c(3040, 208665, 927) # rose pulled from OATH

[nmontalbanocouncil]

@fryenycc Looks good! Couldn't get a part to run because of a LIONs download issue, which is noted below, but I may just be missing something.

code/dsny_biz-complaints-violations_2023.R

• Can you put the full name instead of the acryonym the first time you use it? I'm not sure what dca is

  street_cleanliness_sept23/code/dsny_biz-complaints-violations_2023.R

  Line 32 in 58cea84

  # dca ---------------------------------------------------------------------

• I didn't know this one. I'll be using it in the future

  street_cleanliness_sept23/code/dsny_biz-complaints-violations_2023.R

  Line 59 in 58cea84

  st_make_grid(cellsize = c(2000, 2000), square = FALSE) %>% # 2000 ft

• Is this the right link? I'm not seeing it after downloading the LIONs data but could be missing it

  street_cleanliness_sept23/code/dsny_biz-complaints-violations_2023.R

  Line 157 in 58cea84

  # grab streets from LIONS; zip: 'https://data.cityofnewyork.us/download/2v4z-66xt/application%2Fx-zip-compressed'

• Consider deleting if not using

  street_cleanliness_sept23/code/dsny_biz-complaints-violations_2023.R

  Line 218 in 58cea84

  # commercial waste zones --------------------------------------------------

code/dsny_litter_basket_complaints.R

• add url to download since it is not on github

  street_cleanliness_sept23/code/dsny_litter_basket_complaints.R

  Line 65 in 58cea84

  dcm <- st_read("data/input/DCM_ArterialsMajorStreets.shp", "DCM_ArterialsMajorStreets") %>%

• Consider deleting since not using

  street_cleanliness_sept23/code/dsny_litter_basket_complaints.R

  Line 105 in 58cea84

  # sanitation zones --------------------------------------------------------

[nmontalbanocouncil]

Separate general comments:

• data/olb_over_time.csv is not in an input/output folder
• some leftover blank.txt files
• the names of the files in visuals folder (do with this comment what you please lol)