Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: login #38

Merged
merged 2 commits into from
Aug 16, 2023
Merged

fix: login #38

merged 2 commits into from
Aug 16, 2023

Conversation

chaewonkong
Copy link
Contributor

๐Ÿ‘€ What is this PR?

  1. userId ์™€ localStorage ์˜ id๋ฅผ ๋น„๊ตํ•ด์„œ ๋กœ๊ทธ์ธ ์ฒ˜๋ฆฌ๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.
  2. ๋ฉ”์ธํŽ˜์ด์ง€์—์„œ ๋ฐฉ๋ช…๋ก ๋ฐฐ๋„ˆ๋ฅผ ํด๋ฆญํ•˜๋ฉด ๋ฐฉ๋ช…๋ก ํ™”๋ฉด์œผ๋กœ ์ด๋™ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“ Changes

๐Ÿ“Œ Related issue(s)

๐Ÿ“ท Attachment(optional)

asdf99245
asdf99245 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@asdf99245 asdf99245 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๐Ÿ‘

bsy1141
bsy1141 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@bsy1141 bsy1141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฌ์›ƒ์ด์—์š”

@chaewonkong chaewonkong merged commit 65f05aa into main Aug 16, 2023
2 checks passed
@chaewonkong chaewonkong deleted the fix/login branch August 16, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdf99245 asdf99245 asdf99245 approved these changes

@bsy1141 bsy1141 bsy1141 approved these changes

Assignees

@chaewonkong chaewonkong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaewonkong @asdf99245 @bsy1141